Skip to content

Commit 4fbe69c

Browse files
Document volume delete 409s for ambiguous names
Co-authored-by: shri <shri@metlo.com>
1 parent 78b60a3 commit 4fbe69c

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

‎hyperbrowser/client/managers/async_manager/volume.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ async def get(self, volume_id: str) -> Volume:
4646
return Volume(**response.data)
4747

4848
async def delete(self, volume_id: str) -> VolumeDeleteResult:
49+
"""Delete a volume by id or name. Ambiguous names and active mounts return 409."""
4950
response = await self._client.transport.delete(
5051
self._client._build_url(f"/volume/{volume_id}")
5152
)

‎hyperbrowser/client/managers/sync_manager/volume.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ def get(self, volume_id: str) -> Volume:
4646
return Volume(**response.data)
4747

4848
def delete(self, volume_id: str) -> VolumeDeleteResult:
49+
"""Delete a volume by id or name. Ambiguous names and active mounts return 409."""
4950
response = self._client.transport.delete(
5051
self._client._build_url(f"/volume/{volume_id}")
5152
)

0 commit comments

Comments
 (0)