Add AST call-helper import boundary architecture guard

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

CONTRIBUTING.md

@@ -88,6 +88,7 @@ This runs lint, format checks, compile checks, tests, and package build.
   - `tests/test_agent_task_read_helper_usage.py` (shared agent task read-helper usage enforcement),
   - `tests/test_agent_terminal_status_helper_usage.py` (shared agent terminal-status helper usage enforcement),
   - `tests/test_architecture_marker_usage.py` (architecture marker coverage across guard modules),
+  - `tests/test_ast_call_symbol_helper_import_boundary.py` (shared AST call-helper import boundary enforcement across test modules),
   - `tests/test_ast_function_source_helper_usage.py` (shared AST function-source helper usage enforcement across architecture guard suites),
   - `tests/test_ast_function_source_import_boundary.py` (shared AST function-source helper import boundary enforcement across test modules),
   - `tests/test_ast_function_source_utils.py` (shared AST function-source helper contract validation),

tests/test_architecture_marker_usage.py

@@ -17,6 +17,7 @@
     "tests/test_agent_task_read_helper_usage.py",
     "tests/test_agent_stop_helper_usage.py",
     "tests/test_agent_terminal_status_helper_usage.py",
+    "tests/test_ast_call_symbol_helper_import_boundary.py",
     "tests/test_ast_function_source_helper_usage.py",
     "tests/test_ast_function_source_import_boundary.py",
     "tests/test_ast_function_source_utils.py",

tests/test_ast_call_symbol_helper_import_boundary.py

@@ -0,0 +1,29 @@
+from pathlib import Path
+
+import pytest
+
+from tests.ast_import_utils import imports_symbol_from_module
+
+pytestmark = pytest.mark.architecture
+
+
+EXPECTED_CALLS_SYMBOL_IMPORTERS = (
+    "tests/test_ast_function_source_helper_usage.py",
+    "tests/test_ast_import_helper_usage.py",
+    "tests/test_ast_import_utils.py",
+)
+
+
+def test_calls_symbol_imports_are_centralized():
+    discovered_modules: list[str] = []
+    for module_path in sorted(Path("tests").glob("test_*.py")):
+        module_text = module_path.read_text(encoding="utf-8")
+        if not imports_symbol_from_module(
+            module_text,
+            module="tests.ast_import_utils",
+            symbol="calls_symbol",
+        ):
+            continue
+        discovered_modules.append(module_path.as_posix())
+
+    assert discovered_modules == list(EXPECTED_CALLS_SYMBOL_IMPORTERS)

tests/test_ast_import_helper_usage.py

@@ -2,7 +2,11 @@
 
 import pytest
 
-from tests.ast_import_utils import calls_symbol, imports_imports_collect_function_sources
+from tests.ast_import_utils import (
+    calls_symbol,
+    imports_imports_collect_function_sources,
+    imports_symbol_from_module,
+)
 
 pytestmark = pytest.mark.architecture
 
@@ -17,7 +21,11 @@ def test_ast_import_guard_modules_reuse_shared_import_helper():
     violating_modules: list[str] = []
     for module_path in AST_IMPORT_GUARD_MODULES:
         module_text = Path(module_path).read_text(encoding="utf-8")
-        if not imports_imports_collect_function_sources(module_text):
+        if not imports_symbol_from_module(
+            module_text,
+            module="tests.ast_import_utils",
+            symbol="imports_collect_function_sources",
+        ):
             violating_modules.append(module_path)
             continue
         if not calls_symbol(module_text, "imports_collect_function_sources"):