Harden session recording object parsing

Co-authored-by: Shri Sukhani <shrisukhani@users.noreply.github.com>

Author: cursoragent

hyperbrowser/client/managers/session_utils.py

@@ -45,7 +45,23 @@ def parse_session_recordings_response_data(
                 f"{index} but got {type(recording).__name__}"
             )
         try:
-            parsed_recordings.append(SessionRecording(**dict(recording)))
+            recording_payload = dict(recording)
+        except HyperbrowserError:
+            raise
+        except Exception as exc:
+            raise HyperbrowserError(
+                f"Failed to read session recording object at index {index}",
+                original_error=exc,
+            ) from exc
+        for key in recording_payload.keys():
+            if isinstance(key, str):
+                continue
+            raise HyperbrowserError(
+                "Expected session recording object keys to be strings at index "
+                f"{index}"
+            )
+        try:
+            parsed_recordings.append(SessionRecording(**recording_payload))
         except HyperbrowserError:
             raise
         except Exception as exc:

tests/test_session_recording_utils.py

@@ -1,4 +1,5 @@
 import asyncio
+from collections.abc import Iterator, Mapping
 from types import MappingProxyType
 
 import pytest
@@ -183,6 +184,59 @@ def test_parse_session_recordings_response_data_wraps_invalid_items():
     assert exc_info.value.original_error is not None
 
 
+def test_parse_session_recordings_response_data_wraps_unreadable_recording_items():
+    class _BrokenRecordingMapping(Mapping[str, object]):
+        def __iter__(self) -> Iterator[str]:
+            raise RuntimeError("cannot iterate recording object")
+
+        def __len__(self) -> int:
+            return 1
+
+        def __getitem__(self, key: str) -> object:
+            _ = key
+            return "ignored"
+
+    with pytest.raises(
+        HyperbrowserError,
+        match="Failed to read session recording object at index 0",
+    ) as exc_info:
+        parse_session_recordings_response_data([_BrokenRecordingMapping()])
+
+    assert exc_info.value.original_error is not None
+
+
+def test_parse_session_recordings_response_data_preserves_hyperbrowser_recording_read_errors():
+    class _BrokenRecordingMapping(Mapping[str, object]):
+        def __iter__(self) -> Iterator[str]:
+            raise HyperbrowserError("custom recording read failure")
+
+        def __len__(self) -> int:
+            return 1
+
+        def __getitem__(self, key: str) -> object:
+            _ = key
+            return "ignored"
+
+    with pytest.raises(
+        HyperbrowserError, match="custom recording read failure"
+    ) as exc_info:
+        parse_session_recordings_response_data([_BrokenRecordingMapping()])
+
+    assert exc_info.value.original_error is None
+
+
+def test_parse_session_recordings_response_data_rejects_non_string_recording_keys():
+    with pytest.raises(
+        HyperbrowserError,
+        match="Expected session recording object keys to be strings at index 0",
+    ):
+        parse_session_recordings_response_data(
+            [
+                {1: "bad-key"},  # type: ignore[dict-item]
+            ]
+        )
+
+
 def test_parse_session_recordings_response_data_wraps_unreadable_list_iteration():
     class _BrokenRecordingList(list):
         def __iter__(self):