forked from github/codeql
-
Notifications
You must be signed in to change notification settings - Fork 4
Expand file tree
/
Copy pathCommentController.cs
More file actions
72 lines (61 loc) · 1.94 KB
/
CommentController.cs
File metadata and controls
72 lines (61 loc) · 1.94 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Authorization;
using System.Threading.Tasks;
public class CommentController : Controller
{
private readonly IAuthorizationService _authorizationService;
public CommentController(IAuthorizationService authorizationService)
{
_authorizationService = authorizationService;
}
// BAD: Any user can access this.
public ActionResult Edit1(int commentId, string text)
{
editComment(commentId, text);
return View();
}
// GOOD: The user's authorization is checked.
public ActionResult Edit2(int commentId, string text)
{
if (canEditComment(commentId, User.Identity.Name))
{
editComment(commentId, text);
}
return View();
}
// GOOD: The Authorize attribute is used
[Authorize]
public ActionResult Edit3(int commentId, string text)
{
editComment(commentId, text);
return View();
}
// BAD: The AllowAnonymous attribute overrides the Authorize attribute
[Authorize]
[AllowAnonymous]
public ActionResult Edit4(int commentId, string text)
{
editComment(commentId, text);
return View();
}
// GOOD: An authorization check is made.
public async Task<IActionResult> Edit5(int commentId, string text)
{
var authResult = await _authorizationService.AuthorizeAsync(User, "Comment", "EditPolicy");
if (authResult.Succeeded)
{
editComment(commentId, text);
return View();
}
return Forbid();
}
// GOOD: Only users with the `admin` role can access this method.
[Authorize(Roles = "admin")]
public async Task<IActionResult> Edit6(int commentId, string text)
{
editComment(commentId, text);
return View();
}
void editComment(int commentId, string text) { }
bool canEditComment(int commentId, string userName) { return false; }
}