feat(models)!: reject unknown fields on request models

Generated request models silently dropped unknown keyword arguments
(pydantic's default extra='ignore'), so a typo or a field from a newer
API never reached the server. scripts/patch_model_extra_forbid.py adds
extra='forbid' to every model used as a request body and to the models
nested in them, and the regenerate workflow re-applies it. Response
models are untouched so a newer server still cannot break an older SDK.

BREAKING CHANGE: constructing a request model with an unknown keyword
now raises pydantic.ValidationError.

Author: eddietejeda

.github/workflows/regenerate.yml

@@ -204,6 +204,9 @@ jobs:
       - name: Patch missing-workspace guard into ApiClient
         run: python3 scripts/patch_workspace_guard.py
 
+      - name: Patch request models to reject unknown fields (extra=forbid)
+        run: python3 scripts/patch_model_extra_forbid.py
+
       # The API-token -> JWT key exchange is deprecated: the configured API token
       # is the bearer credential and goes on the wire verbatim. This check is the
       # inverse of the old "did the exchange survive?" guard — it fails if the

CHANGELOG.md

@@ -36,6 +36,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- **Breaking:** request models reject unknown fields. Every model used as a
+  request body (`QueryRequest`, `LoadManagedTableRequest`,
+  `CreateDatabaseRequest`, ... and the models nested in them) now carries
+  `extra="forbid"`, so a misspelled keyword, or a field a newer API has that
+  this SDK release does not know yet, raises `pydantic.ValidationError` at
+  construction instead of being silently dropped from the request. Upgrade the
+  SDK to use a new field. Response models are unchanged: unknown fields in
+  server responses are still ignored, so a newer server never breaks an older
+  SDK.
 - feat(query): add arrow ipc stream response format
 - chore(query): clarify write statement handling in dialect parameter
 - chore(indexes): clarify vector index constraints and algorithms

hotdata/models/add_managed_schema_request.py

@@ -36,6 +36,10 @@ class AddManagedSchemaRequest(BaseModel):
         populate_by_name=True,
         validate_assignment=True,
         protected_namespaces=(),
+        # Hand-applied (scripts/patch_model_extra_forbid.py): this is a
+        # request model, so an unknown keyword is a caller mistake (or a field
+        # this SDK release does not know) and must not be dropped silently.
+        extra="forbid",
     )
 
 

hotdata/models/add_managed_table_decl.py

@@ -40,6 +40,10 @@ class AddManagedTableDecl(BaseModel):
         populate_by_name=True,
         validate_assignment=True,
         protected_namespaces=(),
+        # Hand-applied (scripts/patch_model_extra_forbid.py): this is a
+        # request model, so an unknown keyword is a caller mistake (or a field
+        # this SDK release does not know) and must not be dropped silently.
+        extra="forbid",
     )
 
 

hotdata/models/add_managed_table_request.py

@@ -40,6 +40,10 @@ class AddManagedTableRequest(BaseModel):
         populate_by_name=True,
         validate_assignment=True,
         protected_namespaces=(),
+        # Hand-applied (scripts/patch_model_extra_forbid.py): this is a
+        # request model, so an unknown keyword is a caller mistake (or a field
+        # this SDK release does not know) and must not be dropped silently.
+        extra="forbid",
     )
 
 

hotdata/models/attach_database_catalog_request.py

@@ -35,6 +35,10 @@ class AttachDatabaseCatalogRequest(BaseModel):
         populate_by_name=True,
         validate_assignment=True,
         protected_namespaces=(),
+        # Hand-applied (scripts/patch_model_extra_forbid.py): this is a
+        # request model, so an unknown keyword is a caller mistake (or a field
+        # this SDK release does not know) and must not be dropped silently.
+        extra="forbid",
     )
 
 

hotdata/models/batch_create_upload_request.py

@@ -35,6 +35,10 @@ class BatchCreateUploadRequest(BaseModel):
         populate_by_name=True,
         validate_assignment=True,
         protected_namespaces=(),
+        # Hand-applied (scripts/patch_model_extra_forbid.py): this is a
+        # request model, so an unknown keyword is a caller mistake (or a field
+        # this SDK release does not know) and must not be dropped silently.
+        extra="forbid",
     )
 
 

hotdata/models/bulk_create_databases_request.py

@@ -42,6 +42,10 @@ class BulkCreateDatabasesRequest(BaseModel):
         populate_by_name=True,
         validate_assignment=True,
         protected_namespaces=(),
+        # Hand-applied (scripts/patch_model_extra_forbid.py): this is a
+        # request model, so an unknown keyword is a caller mistake (or a field
+        # this SDK release does not know) and must not be dropped silently.
+        extra="forbid",
     )
 
 

hotdata/models/column_type_spec.py

@@ -37,6 +37,10 @@ class ColumnTypeSpec(BaseModel):
         populate_by_name=True,
         validate_assignment=True,
         protected_namespaces=(),
+        # Hand-applied (scripts/patch_model_extra_forbid.py): this is a
+        # request model, so an unknown keyword is a caller mistake (or a field
+        # this SDK release does not know) and must not be dropped silently.
+        extra="forbid",
     )
 
 

hotdata/models/create_connection_request.py

@@ -38,6 +38,10 @@ class CreateConnectionRequest(BaseModel):
         populate_by_name=True,
         validate_assignment=True,
         protected_namespaces=(),
+        # Hand-applied (scripts/patch_model_extra_forbid.py): this is a
+        # request model, so an unknown keyword is a caller mistake (or a field
+        # this SDK release does not know) and must not be dropped silently.
+        extra="forbid",
     )