Skip to content

Commit 595dc8e

Browse files
agnersclaude
andauthored
Allow ipv4 and ipv6 to be None in NetworkInterface (#286)
The Supervisor API can return null for ipv4/ipv6 on interfaces that have no configuration. Update fixture and test assertions to cover this. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 0458e6a commit 595dc8e

3 files changed

Lines changed: 6 additions & 20 deletions

File tree

aiohasupervisor/models/network.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,8 @@ class NetworkInterface(ResponseData):
137137
connected: bool
138138
primary: bool
139139
mac: str
140-
ipv4: IPv4
141-
ipv6: IPv6
140+
ipv4: IPv4 | None
141+
ipv6: IPv6 | None
142142
wifi: Wifi | None
143143
vlan: Vlan | None
144144
mdns: MulticastDnsMode | None

tests/fixtures/network_info.json

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -39,24 +39,8 @@
3939
"connected": false,
4040
"primary": false,
4141
"mac": "00:11:22:33:44:55",
42-
"ipv4": {
43-
"method": "disabled",
44-
"address": [],
45-
"nameservers": [],
46-
"gateway": null,
47-
"ready": false,
48-
"route_metric": null
49-
},
50-
"ipv6": {
51-
"method": "disabled",
52-
"address": [],
53-
"nameservers": [],
54-
"gateway": null,
55-
"ready": false,
56-
"route_metric": null,
57-
"addr_gen_mode": "default",
58-
"ip6_privacy": "default"
59-
},
42+
"ipv4": null,
43+
"ipv6": null,
6044
"wifi": null,
6145
"vlan": null,
6246
"mdns": null,

tests/test_network.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ async def test_network_info(
5959
assert result.interfaces[1].interface == "end0.10"
6060
assert result.interfaces[1].type == "vlan"
6161
assert result.interfaces[1].enabled is False
62+
assert result.interfaces[1].ipv4 is None
63+
assert result.interfaces[1].ipv6 is None
6264
assert result.interfaces[1].mdns is None
6365
assert result.interfaces[1].llmnr is None
6466

0 commit comments

Comments
 (0)