Activate all ruff rules (#1)

Author: edenhaus

go2rtc_client/client.py

@@ -2,9 +2,8 @@
 
 from __future__ import annotations
 
-from collections.abc import Mapping
 import logging
-from typing import Any, Final, Literal
+from typing import TYPE_CHECKING, Any, Final, Literal
 from urllib.parse import urljoin
 
 from aiohttp import ClientError, ClientResponse, ClientSession
@@ -14,6 +13,9 @@
 
 from .models import Stream, WebRTCSdpAnswer, WebRTCSdpOffer
 
+if TYPE_CHECKING:
+    from collections.abc import Mapping
+
 _LOGGER = logging.getLogger(__name__)
 
 _API_PREFIX = "/api"
@@ -48,7 +50,8 @@ async def request(
         try:
             resp = await self._session.request(method, url, **kwargs)
         except ClientError as err:
-            raise ClientError(f"Server communication failure: {err}") from err
+            msg = f"Server communication failure: {err}"
+            raise ClientError(msg) from err
 
         resp.raise_for_status()
         return resp

pyproject.toml

@@ -140,14 +140,16 @@ max-line-length = 88
 addopts = "--cov"
 asyncio_mode = "auto"
 
-[tool.lint.ruff]
+[tool.ruff.lint]
 ignore = [
   "ANN101", # Self... explanatory
   "ANN102", # cls... just as useless
   "ANN401", # Opinioated warning on disallowing dynamically typed expressions
+  "COM812", # Recommended to disable due conflicts with ruff format
   "D203", # Conflicts with other rules
   "D213", # Conflicts with other rules
   "D417", # False positives in some occasions
+  "ISC001", # Recommended to disable due conflicts with ruff format
   "PLR2004", # Just annoying, not really useful
   "PLR0913", # Too many arguments
 ]

tests/conftest.py

@@ -5,12 +5,12 @@
 import aiohttp
 from aioresponses import aioresponses
 import pytest
+from syrupy import SnapshotAssertion
 
 from go2rtc_client import Go2RtcClient
-from syrupy import SnapshotAssertion
 
-from .syrupy import Go2RtcSnapshotExtension
 from . import URL
+from .syrupy import Go2RtcSnapshotExtension
 
 
 @pytest.fixture(name="snapshot")

tests/test_client.py

@@ -4,20 +4,21 @@
 
 from typing import TYPE_CHECKING
 
-from aioresponses import aioresponses
+from aiohttp.hdrs import METH_PUT
 import pytest
 
-from go2rtc_client.models import WebRTCSdpOffer
-from . import URL
-
-from go2rtc_client import Go2RtcClient
 from go2rtc_client.client import _StreamClient, _WebRTCClient
+from go2rtc_client.models import WebRTCSdpOffer
 from tests import load_fixture
-from aiohttp.hdrs import METH_PUT
+
+from . import URL
 
 if TYPE_CHECKING:
+    from aioresponses import aioresponses
     from syrupy import SnapshotAssertion
 
+    from go2rtc_client import Go2RtcClient
+
 
 @pytest.mark.parametrize(
     "filename",