diff --git a/apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts b/apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts index 9497f536ab019..69fdd59fcb5fd 100644 --- a/apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts +++ b/apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts @@ -1320,6 +1320,7 @@ export const CODEX_THREAD_CONFIG = { mcp_optional_startup_grace_ms: 10_000, } as const; +// Coder: exported for CodexAdapterV2.test.ts, which checks T3CODE_THREAD_ID without the MCP servers. export function codexThreadRuntimeParams(input: { readonly threadId: ThreadId | null; readonly mcpSession: McpProviderSession.McpProviderSessionConfig | undefined; diff --git a/apps/web/src/components/pullRequest/PullRequestStackMenu.tsx b/apps/web/src/components/pullRequest/PullRequestStackMenu.tsx index 8f73c1182aff6..8ed8ba2d8ed33 100644 --- a/apps/web/src/components/pullRequest/PullRequestStackMenu.tsx +++ b/apps/web/src/components/pullRequest/PullRequestStackMenu.tsx @@ -159,7 +159,7 @@ export function PullRequestStackMenu({ } /> - View stack !{stack.number}, layer {position} of {stack.layers.length} + View stack #{stack.number}, layer {position} of {stack.layers.length} {notice ? ` ยท ${notice}` : null} @@ -249,7 +249,7 @@ export function PullRequestStackMenu({ {confirmation === "merge" - ? `Merge !${reference.number} and its unmerged layers below into ${stack.base} using ${mergeMethod}. ${hostLabel} checks their rules before merging or queueing them and rebases the remaining stack after merging.` + ? `Merge #${reference.number} and its unmerged layers below into ${stack.base} using ${mergeMethod}. ${hostLabel} checks their rules before merging or queueing them and rebases the remaining stack after merging.` : `Rebase the remote branches from bottom to top onto ${stack.base}. This rewrites branch history and may restart checks. If a layer fails, earlier updates remain.`} diff --git a/docs/internals/coder-only.md b/docs/internals/coder-only.md index fd9b4bcc53481..ab63618738d7e 100644 --- a/docs/internals/coder-only.md +++ b/docs/internals/coder-only.md @@ -1063,7 +1063,7 @@ checks that every name here still exists and that every modified upstream file i `AgentScope.test.ts` drops the launcher check (`agentScopeLauncherScript` is cut); `GitLabPullRequestCli.legacy.test.ts` expects `DIFF_MAX_OUTPUT_BYTES`; `ProviderReplayFixtures.ts` lists only the carried drivers; `CodexAdapterV2.test.ts` expects `T3CODE_THREAD_ID` without - the MCP servers; client-runtime's `assets.test.ts` builds the gateway `ConnectionTarget` in + the MCP servers (through `codexThreadRuntimeParams`, exported for it); client-runtime's `assets.test.ts` builds the gateway `ConnectionTarget` in place of upstream's primary target; `ChatView.logic.test.ts` drops preview annotations, `useThreadActions.permissions.test.ts` the mini-player state, `mediaContent.test.ts` the desktop media read, and `settingsSearch.test.ts` the browser search row. diff --git a/knip.jsonc b/knip.jsonc index 389b6951e60b8..16a4f88130084 100644 --- a/knip.jsonc +++ b/knip.jsonc @@ -107,6 +107,7 @@ "packages/provider-core/src/server/maintenanceResolver.ts": ["exports", "nsExports"], "packages/provider-core/src/server/mcpSession.ts": ["exports", "nsExports"], "packages/provider-core/src/server/orchestrationInstructions.ts": ["exports", "nsExports"], + "packages/provider-core/src/server/runtimeInstructions.ts": ["exports", "nsExports"], "packages/provider-core/src/server/snapshotProbe.ts": ["exports", "nsExports"], "packages/provider-core/src/server/textGenerationOperations.ts": ["exports", "nsExports"], "packages/provider-testing/src/fakeCli.ts": ["exports", "nsExports"],