fix(graphile-build-pg): add more numeric casting exceptions (#661)

Co-authored-by: Wessel van der Veen <wvn@synadia.nl>
Co-authored-by: Benjie Gillam <benjie@jemjie.com>

Author: 3 people

packages/graphile-build-pg/src/QueryBuilder.js

@@ -57,6 +57,16 @@ function escapeLarge(sqlFragment: SQL, type: PgType) {
         "23" /* int4 */,
         "700" /* float4 */,
         "701" /* float8 */,
+        "24" /* regproc */,
+        "2202" /* regprocedure */,
+        "2203" /* regoper */,
+        "2204" /* regoperator */,
+        "2205" /* regclass */,
+        "2206" /* regtype */,
+        "4096" /* regrole */,
+        "4089" /* regnamespace */,
+        "3734" /* regconfig */,
+        "3769" /* regdictionary */,
       ].includes(actualType.id)
     ) {
       // No need for special handling

packages/graphile-build-pg/src/plugins/PgTypesPlugin.js

@@ -357,6 +357,46 @@ export default (function PgTypesPlugin(
         inflection.builtin("InternetAddress"),
         "An IPv4 or IPv6 host address, and optionally its subnet."
       );
+      const RegProcType = stringType(
+        inflection.builtin("RegProc"),
+        "A builtin object identifier type for a function name"
+      );
+      const RegProcedureType = stringType(
+        inflection.builtin("RegProcedure"),
+        "A builtin object identifier type for a function with argument types"
+      );
+      const RegOperType = stringType(
+        inflection.builtin("RegOper"),
+        "A builtin object identifier type for an operator"
+      );
+      const RegOperatorType = stringType(
+        inflection.builtin("RegOperator"),
+        "A builtin object identifier type for an operator with argument types"
+      );
+      const RegClassType = stringType(
+        inflection.builtin("RegClass"),
+        "A builtin object identifier type for a relation name"
+      );
+      const RegTypeType = stringType(
+        inflection.builtin("RegType"),
+        "A builtin object identifier type for a data type name"
+      );
+      const RegRoleType = stringType(
+        inflection.builtin("RegRole"),
+        "A builtin object identifier type for a role name"
+      );
+      const RegNamespaceType = stringType(
+        inflection.builtin("RegNamespace"),
+        "A builtin object identifier type for a namespace name"
+      );
+      const RegConfigType = stringType(
+        inflection.builtin("RegConfig"),
+        "A builtin object identifier type for a text search configuration"
+      );
+      const RegDictionaryType = stringType(
+        inflection.builtin("RegDictionary"),
+        "A builtin object identifier type for a text search dictionary"
+      );
       const CidrType = pgUseCustomNetworkScalars
         ? stringType(
             inflection.builtin("CidrAddress"),
@@ -424,6 +464,16 @@ export default (function PgTypesPlugin(
       addType(DateType, "graphile-build-pg built-in");
       addType(DateTimeType, "graphile-build-pg built-in");
       addType(TimeType, "graphile-build-pg built-in");
+      addType(RegProcType, "graphile-build-pg built-in");
+      addType(RegProcedureType, "graphile-build-pg built-in");
+      addType(RegOperType, "graphile-build-pg built-in");
+      addType(RegOperatorType, "graphile-build-pg built-in");
+      addType(RegClassType, "graphile-build-pg built-in");
+      addType(RegTypeType, "graphile-build-pg built-in");
+      addType(RegRoleType, "graphile-build-pg built-in");
+      addType(RegNamespaceType, "graphile-build-pg built-in");
+      addType(RegConfigType, "graphile-build-pg built-in");
+      addType(RegDictionaryType, "graphile-build-pg built-in");
 
       const oidLookup = {
         20: stringType(
@@ -461,6 +511,16 @@ export default (function PgTypesPlugin(
         650: CidrType,
         829: MacAddrType,
         774: MacAddr8Type,
+        24: RegProcType,
+        2202: RegProcedureType,
+        2203: RegOperType,
+        2204: RegOperatorType,
+        2205: RegClassType,
+        2206: RegTypeType,
+        4096: RegRoleType,
+        4089: RegNamespaceType,
+        3734: RegConfigType,
+        3769: RegDictionaryType,
       };
       const oidInputLookup = {
         1186: GQLIntervalInput, // interval

packages/postgraphile-core/__tests__/fixtures/mutations/pg10.types.graphql

@@ -0,0 +1,35 @@
+mutation {
+  # Must come next to last
+  updateTypeById(
+    input: {
+      id: 12
+      typePatch: {
+        regrole: "postgraphile_test_authenticator"
+        regnamespace: "pg10"
+      }
+    }
+  ) {
+    type {
+      ...type
+    }
+  }
+  # Must come last
+  createType(
+    input: {
+      type: {
+        regrole: "postgraphile_test_visitor"
+        regnamespace: "c"
+      }
+    }
+  ) {
+    type {
+      ...type
+    }
+  }
+}
+
+fragment type on Type {
+  id
+  regrole
+  regnamespace
+}

packages/postgraphile-core/__tests__/fixtures/mutations/types.graphql

@@ -55,6 +55,14 @@ mutation {
         money: 27
         compoundType: { a: 1 }
         nestedCompoundType: { a: { a: 1 } }
+        regproc: "b.type_function" 
+        regprocedure: "b.type_function(int)" 
+        regoper: "*<>"
+        regoperator: "+(integer, integer)"
+        regclass: "c.person" 
+        regtype: "numeric" 
+        regconfig: "dutch"
+        regdictionary: "dutch_stem"
       }
     }
   ) {
@@ -102,6 +110,14 @@ mutation {
         money: 27
         compoundType: { a: 1 }
         nestedCompoundType: { a: { a: 1 } }
+        regproc: "b.type_function" 
+        regprocedure: "b.type_function(int)" 
+        regoper: "*<>"
+        regoperator: "+(integer, integer)"
+        regclass: "c.person" 
+        regtype: "numeric" 
+        regconfig: "dutch"
+        regdictionary: "dutch_stem"
       }
     }
   ) {
@@ -122,6 +138,7 @@ fragment compoundType on CompoundType {
 }
 
 fragment type on Type {
+  id
   smallint
   bigint
   boolean
@@ -195,4 +212,12 @@ fragment type on Type {
     x
     y
   }
+  regproc
+  regprocedure
+  regoper
+  regoperator
+  regclass
+  regtype
+  regconfig
+  regdictionary
 }

packages/postgraphile-core/__tests__/fixtures/queries/pg10.types.graphql

@@ -0,0 +1,29 @@
+query {
+  allTypes {
+    ...typesConnection
+  }
+}
+
+fragment type on Type {
+  id
+  regrole
+  regnamespace
+}
+
+fragment typesConnection on TypesConnection {
+  nodes {
+    ...type
+  }
+  edges {
+    node {
+      ...type
+    }
+  }
+  totalCount
+  pageInfo {
+    hasNextPage
+    hasPreviousPage
+    startCursor
+    endCursor
+  }
+}

packages/postgraphile-core/__tests__/fixtures/queries/types.graphql

@@ -57,6 +57,7 @@ fragment compoundType on CompoundType {
 }
 
 fragment type on Type {
+  id
   smallint
   bigint
   boolean
@@ -138,6 +139,14 @@ fragment type on Type {
     id
     headline
   }
+  regproc
+  regprocedure
+  regoper
+  regoperator
+  regclass
+  regtype
+  regconfig
+  regdictionary
 }
 
 fragment typesConnection on TypesConnection {