fix(utils): fix smart tags for attributes

Author: benjie

packages/graphile-utils/__tests__/__snapshots__/makePgSmartTagsPlugin.test.js.snap

@@ -249,7 +249,7 @@ type TestSmartTag implements Node {
   """
   nodeId: ID!
   email: String!
-  value: Int
+  val: Int
 
   """Reads a single \`User\` that is related to this \`TestSmartTag\`."""
   userByEmail: User
@@ -263,8 +263,8 @@ input TestSmartTagCondition {
   """Checks for equality with the object’s \`email\` field."""
   email: String
 
-  """Checks for equality with the object’s \`value\` field."""
-  value: Int
+  """Checks for equality with the object’s \`val\` field."""
+  val: Int
 }
 
 """A connection to a list of \`TestSmartTag\` values."""
@@ -298,8 +298,8 @@ enum TestSmartTagsOrderBy {
   NATURAL
   EMAIL_ASC
   EMAIL_DESC
-  VALUE_ASC
-  VALUE_DESC
+  VAL_ASC
+  VAL_DESC
   PRIMARY_KEY_ASC
   PRIMARY_KEY_DESC
 }

packages/graphile-utils/__tests__/makePgSmartTagsPlugin.test.js

@@ -32,6 +32,13 @@ it("allows adding a custom single field to PG schema", async () => {
                 primaryKey: "email",
                 foreignKey: "(email) references graphile_utils.users (email)",
               },
+              attribute: {
+                value: {
+                  tags: {
+                    name: "val",
+                  },
+                },
+              },
             },
           },
         },
@@ -50,7 +57,7 @@ it("allows adding a custom single field to PG schema", async () => {
               email
               testSmartTagByEmail {
                 email
-                value
+                val
               }
             }
           }
@@ -74,14 +81,14 @@ it("allows adding a custom single field to PG schema", async () => {
               "email": "bob@example.com",
               "testSmartTagByEmail": Object {
                 "email": "bob@example.com",
-                "value": 42,
+                "val": 42,
               },
             },
             Object {
               "email": "caroline@example.com",
               "testSmartTagByEmail": Object {
                 "email": "caroline@example.com",
-                "value": 9999,
+                "val": 9999,
               },
             },
           ],

packages/graphile-utils/src/makePgSmartTagsPlugin.ts

@@ -134,13 +134,24 @@ export function makePgSmartTagsPlugin(
               pgIntrospectionResultsByKind
             );
           }
+
+          /**
+           * The introspection results aren't currently on Build (we're helping
+           * this happen now!), so we're going to fake it to make the API more
+           * straightforward
+           */
+          const buildWithIntrospection = {
+            ...build,
+            pgIntrospectionResultsByKind,
+          };
+
           rules.forEach((rule, idx) => {
             const relevantIntrospectionResults: PgEntity[] =
               pgIntrospectionResultsByKind[rule.kind];
 
             let hits = 0;
             relevantIntrospectionResults.forEach(entity => {
-              if (!rule.match(entity, build)) {
+              if (!rule.match(entity, buildWithIntrospection)) {
                 return;
               }
               hits++;