fix(utils): only apply condition when specified (#572)

benjie · web-flow · commit 314fce122995 · 2019-12-11T12:07:12.000Z
diff --git a/packages/graphile-utils/src/makeAddPgTableConditionPlugin.ts b/packages/graphile-utils/src/makeAddPgTableConditionPlugin.ts
@@ -107,7 +107,7 @@ export default function makeAddPgTableConditionPlugin(
         }: {
           condition: { [key: string]: any } | null;
         }) {
-          if (!condition) {
+          if (!condition || !(conditionFieldName in condition)) {
             return {};
           }
           const { [conditionFieldName]: conditionValue } = condition;

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ export default function makeAddPgTableConditionPlugin(`
`107`	`107`	`}: {`
`108`	`108`	`condition: { [key: string]: any } \| null;`
`109`	`109`	`}) {`
`110`		`- if (!condition) {`
	`110`	`+ if (!condition \|\| !(conditionFieldName in condition)) {`
`111`	`111`	`return {};`
`112`	`112`	`}`
`113`	`113`	`const { [conditionFieldName]: conditionValue } = condition;`