chore: revert breaking fake enum name change (#682)

Author: benjie

packages/graphile-build-pg/src/plugins/PgIntrospectionPlugin.js

@@ -715,8 +715,7 @@ Original error: ${e.message}
 
                   // Create fake enum type
                   const constraintIdent =
-                    (constraint.type === "p" ? "" : `_${constraint.name}`) +
-                    "_fake_enum";
+                    constraint.type === "p" ? "" : `_${constraint.name}`;
                   const enumTypeArray = {
                     kind: "type",
                     isFake: true,

packages/postgraphile-core/__tests__/integration/schema/__snapshots__/enum_tables.test.js.snap

@@ -208,20 +208,6 @@ enum EnumTheSecond {
   B4
 }
 
-enum EnumTheThird {
-  """Desc C1"""
-  C1
-
-  """Desc C2"""
-  C2
-
-  """Desc C3"""
-  C3
-
-  """Desc C4"""
-  C4
-}
-
 enum LetterAToD {
   """The letter A"""
   A
@@ -319,6 +305,20 @@ enum LetterDescriptionsOrderBy {
   PRIMARY_KEY_DESC
 }
 
+enum LotsOfEnumsEnum3 {
+  """Desc C1"""
+  C1
+
+  """Desc C2"""
+  C2
+
+  """Desc C3"""
+  C3
+
+  """Desc C4"""
+  C4
+}
+
 """
 The root mutation type which contains root level fields which mutate data.
 """
@@ -553,7 +553,7 @@ type Query implements Node {
 type ReferencingTable implements Node {
   enum1: EnumTheFirst
   enum2: EnumTheSecond
-  enum3: EnumTheThird
+  enum3: LotsOfEnumsEnum3
   id: Int!
 
   """
@@ -574,7 +574,7 @@ input ReferencingTableCondition {
   enum2: EnumTheSecond
 
   """Checks for equality with the object’s \`enum3\` field."""
-  enum3: EnumTheThird
+  enum3: LotsOfEnumsEnum3
 
   """Checks for equality with the object’s \`id\` field."""
   id: Int
@@ -584,7 +584,7 @@ input ReferencingTableCondition {
 input ReferencingTableInput {
   enum1: EnumTheFirst
   enum2: EnumTheSecond
-  enum3: EnumTheThird
+  enum3: LotsOfEnumsEnum3
   id: Int
 }
 
@@ -619,7 +619,7 @@ Represents an update to a \`ReferencingTable\`. Fields that are set will be upda
 input ReferencingTablePatch {
   enum1: EnumTheFirst
   enum2: EnumTheSecond
-  enum3: EnumTheThird
+  enum3: LotsOfEnumsEnum3
   id: Int
 }
 

packages/postgraphile-core/__tests__/kitchen-sink-schema.sql

@@ -1165,8 +1165,8 @@ create table enum_tables.lots_of_enums (
 comment on table enum_tables.lots_of_enums is E'@omit';
 comment on constraint enum_1 on enum_tables.lots_of_enums is E'@enum\n@enumName EnumTheFirst';
 comment on constraint enum_2 on enum_tables.lots_of_enums is E'@enum\n@enumName EnumTheSecond';
-comment on constraint enum_3 on enum_tables.lots_of_enums is E'@enum\n@enumName EnumTheThird';
-comment on constraint enum_4 on enum_tables.lots_of_enums is E'@enum\n@enumName EnumTheFourth';
+comment on constraint enum_3 on enum_tables.lots_of_enums is E'@enum';
+comment on constraint enum_4 on enum_tables.lots_of_enums is E'@enum';
 
 -- Enum table needs values added as part of the migration, not as part of the
 -- data.