Skip to content

Update to Go 1.20 and React with line numbers#80

Merged
nevkontakte merged 5 commits into
gopherjs:masterfrom
grantnelson-wf:updateTo1_19
May 12, 2026
Merged

Update to Go 1.20 and React with line numbers#80
nevkontakte merged 5 commits into
gopherjs:masterfrom
grantnelson-wf:updateTo1_19

Conversation

@grantnelson-wf

@grantnelson-wf grantnelson-wf commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

I'm doing a lot of experimentation and improvements to the GopherJS playground.

@grantnelson-wf grantnelson-wf changed the title [WIP] Update to Go 1.19 and React with line numbers [WIP] Update to Go 1.20 and React with line numbers Jan 16, 2026
@grantnelson-wf grantnelson-wf force-pushed the updateTo1_19 branch 5 times, most recently from 378a7c1 to e9dfcbe Compare March 24, 2026 22:22
@grantnelson-wf grantnelson-wf changed the title [WIP] Update to Go 1.20 and React with line numbers Update to Go 1.20 and React with line numbers Mar 24, 2026
@grantnelson-wf grantnelson-wf marked this pull request as ready for review March 24, 2026 22:33

@nevkontakte nevkontakte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be honest and admit that I gave a cursory look to most of the code here.

Personally, I feel like React is a bit of an overkill for what Playground is, but it's an iprovement over the status quo, and if nothing else a pretty useful tech demo, so I have no real objection.

Thanks!

Comment thread playground/internal/cmd/compile/internal/compiler.go Outdated
@grantnelson-wf

grantnelson-wf commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

Personally, I feel like React is a bit of an overkill for what Playground is, but it's an iprovement over the status quo, and if nothing else a pretty useful tech demo, so I have no real objection.

Yeah, React is a little overkill. This totally was totally a tech demo (I wanted it in as much Go as possible) and a learning tool for me to try out things I haven't done much of before, and I probably went overboard since I was having fun. I tinkered on this project on the side for several months while waiting for some CI to finish, between meetings, and even during very slow boring meetings. It has lots of room for improvement and I hope many people add to it.

Note: I can not merge this work since I don't have permissions to gopherjs.github.io like I do for gopherjs, so I'll need your help merging once this is ready.

@nevkontakte nevkontakte merged commit c46b032 into gopherjs:master May 12, 2026
2 checks passed
@grantnelson-wf grantnelson-wf deleted the updateTo1_19 branch May 12, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants