test(scripts): minimize feature metadata regression coverage

Author: grafvonb

tests/test_timestamp_branches.py

@@ -15,6 +15,12 @@
 PROJECT_ROOT = Path(__file__).resolve().parent.parent
 CREATE_FEATURE = PROJECT_ROOT / "scripts" / "bash" / "create-new-feature.sh"
 CREATE_FEATURE_PS = PROJECT_ROOT / "scripts" / "powershell" / "create-new-feature.ps1"
+EXT_CREATE_FEATURE = (
+    PROJECT_ROOT / "extensions" / "git" / "scripts" / "bash" / "create-new-feature.sh"
+)
+EXT_CREATE_FEATURE_PS = (
+    PROJECT_ROOT / "extensions" / "git" / "scripts" / "powershell" / "create-new-feature.ps1"
+)
 COMMON_SH = PROJECT_ROOT / "scripts" / "bash" / "common.sh"
 
 
@@ -106,7 +112,7 @@ def test_json_output_keys(self, git_repo: Path):
         assert re.match(r"^\d{8}-\d{6}$", data["FEATURE_NUM"])
 
     def test_writes_feature_metadata_file(self, git_repo: Path):
-        """The create script persists .specify/feature.json for downstream commands."""
+        """Feature creation persists .specify/feature.json with the created spec dir."""
         import json
 
         result = run_script(git_repo, "--json", "--short-name", "meta-test", "Metadata test")
@@ -450,6 +456,35 @@ def test_powershell_supports_allow_existing_branch_flag(self):
         # Ensure the flag is referenced in script logic, not just declared
         assert "AllowExistingBranch" in contents.replace("-AllowExistingBranch", "")
 
+    def test_powershell_persists_feature_metadata(self):
+        """Static guard: PS script writes .specify/feature.json."""
+        contents = CREATE_FEATURE_PS.read_text(encoding="utf-8")
+        assert "feature_directory = \"specs/$branchName\"" in contents
+        assert "feature.json" in contents
+
+    def test_powershell_surfaces_checkout_errors(self):
+        """Static guard: PS script preserves checkout stderr on existing-branch failures."""
+        contents = CREATE_FEATURE_PS.read_text(encoding="utf-8")
+        assert "exists but could not be checked out" in contents
+
+
+class TestGitExtensionParity:
+    def test_bash_extension_surfaces_checkout_errors(self):
+        """Static guard: git extension bash script preserves checkout stderr."""
+        if not EXT_CREATE_FEATURE.exists():
+            pytest.skip("git extension bash script not present in this checkout")
+        contents = EXT_CREATE_FEATURE.read_text(encoding="utf-8")
+        assert 'switch_branch_error=$(git checkout -q "$BRANCH_NAME" 2>&1)' in contents
+        assert "Failed to switch to existing branch '$BRANCH_NAME'" in contents
+
+    def test_powershell_extension_surfaces_checkout_errors(self):
+        """Static guard: git extension PowerShell script preserves checkout stderr."""
+        if not EXT_CREATE_FEATURE_PS.exists():
+            pytest.skip("git extension PowerShell script not present in this checkout")
+        contents = EXT_CREATE_FEATURE_PS.read_text(encoding="utf-8")
+        assert "$switchBranchError = git checkout -q $branchName 2>&1 | Out-String" in contents
+        assert "exists but could not be checked out.`n$($switchBranchError.Trim())" in contents
+
 
 # ── Dry-Run Tests ────────────────────────────────────────────────────────────
 
@@ -787,18 +822,3 @@ def test_ps_dry_run_json_absent_without_flag(self, ps_git_repo: Path):
         assert result.returncode == 0, result.stderr
         data = json.loads(result.stdout)
         assert "DRY_RUN" not in data, f"DRY_RUN should not be in normal JSON: {data}"
-
-    def test_ps_writes_feature_metadata_file(self, ps_git_repo: Path):
-        """PowerShell create script persists .specify/feature.json."""
-        import json
-
-        result = run_ps_script(
-            ps_git_repo, "-Json", "-ShortName", "ps-meta", "PowerShell metadata"
-        )
-        assert result.returncode == 0, result.stderr
-        data = json.loads(result.stdout)
-
-        metadata_file = ps_git_repo / ".specify" / "feature.json"
-        assert metadata_file.exists(), "feature metadata file was not created"
-        metadata = json.loads(metadata_file.read_text(encoding="utf-8-sig"))
-        assert metadata == {"feature_directory": f"specs/{data['BRANCH_NAME']}"}