Add coverage for YAML option in differ spec

Author: Kevin Paulisse

lib/octocatalog-diff/catalog-diff/filter.rb

@@ -30,7 +30,7 @@ def self.filter(result, filter_class_name, options = {})
       # Inherited: Construct a default `filtered?` method for the subclass via inheritance.
       # Each subclass must implement this method, so the default method errors.
       def self.filtered?(_item, _options = {})
-        raise "No `filtered?` method is implemented in #{self.class.name}"
+        raise "No `filtered?` method is implemented in #{name}"
       end
     end
   end

spec/octocatalog-diff/fixtures/catalogs/ignore-equivalent-yaml-1.json

@@ -0,0 +1,22 @@
+{
+  "document_type": "Catalog",
+  "data": {
+    "tags": ["settings"],
+    "name": "my.rspec.node",
+    "version": "production",
+    "environment": "production",
+    "resources": [
+      {
+        "type": "File",
+        "title": "/tmp/foo.yaml",
+        "exported": false,
+        "parameters": {
+          "content": "foo:\n  bar: baz\n"
+        }
+      }
+    ]
+  },
+  "metadata": {
+    "api_version": 1
+  }
+}

spec/octocatalog-diff/fixtures/catalogs/ignore-equivalent-yaml-2.json

@@ -0,0 +1,22 @@
+{
+  "document_type": "Catalog",
+  "data": {
+    "tags": ["settings"],
+    "name": "my.rspec.node",
+    "version": "production",
+    "environment": "production",
+    "resources": [
+      {
+        "type": "File",
+        "title": "/tmp/foo.yaml",
+        "exported": false,
+        "parameters": {
+          "content": "---\n  foo:\n    bar: baz\n"
+        }
+      }
+    ]
+  },
+  "metadata": {
+    "api_version": 1
+  }
+}

spec/octocatalog-diff/tests/catalog-diff/differ_spec.rb

@@ -662,6 +662,29 @@
     end
   end
 
+  context 'additional pluggable filters' do
+    context 'equivalent YAML files with different text representations' do
+      before(:all) do
+        @c1 = OctocatalogDiff::Catalog.new(json: OctocatalogDiff::Spec.fixture_read('catalogs/ignore-equivalent-yaml-1.json'))
+        @c2 = OctocatalogDiff::Catalog.new(json: OctocatalogDiff::Spec.fixture_read('catalogs/ignore-equivalent-yaml-2.json'))
+      end
+
+      it 'should filter when filter is enabled' do
+        opts = { ignore_equivalent_yaml_files: true }
+        testobj = OctocatalogDiff::CatalogDiff::Differ.new(opts, @c1, @c2)
+        result = testobj.diff
+        expect(result.size).to eq(0)
+      end
+
+      it 'should not filter when filter is disabled' do
+        opts = {}
+        testobj = OctocatalogDiff::CatalogDiff::Differ.new(opts, @c1, @c2)
+        result = testobj.diff
+        expect(result.size).to eq(1)
+      end
+    end
+  end
+
   context 'ignoring specific changes in attributes' do
     before(:all) do
       @c1 = OctocatalogDiff::Catalog.new(json: OctocatalogDiff::Spec.fixture_read('catalogs/ignore-enhanced-changes-1.json'))