Proper exception raising from serialized execution too

Author: kpaulisse

lib/octocatalog-diff/util/parallel.rb

@@ -152,6 +152,7 @@ def self.run_tasks_serial(result, task_array, logger)
         task_array.each_with_index do |ele, task_counter|
           result[task_counter] = execute_task(ele, logger)
           break unless result[task_counter].status
+          raise result[task_counter].exception
         end
       end
 
@@ -166,7 +167,7 @@ def self.execute_task(task, logger)
           result = Result.new(output: output, status: true, args: task.args)
         rescue => exc
           logger.debug("Failed #{task.description}: #{exc.class} #{exc.message}")
-          return Result.new(exception: exc, status: false, args: task.args)
+          result = Result.new(exception: exc, status: false, args: task.args)
         end
 
         begin

spec/octocatalog-diff/integration/reference_validation_spec.rb

@@ -327,7 +327,7 @@ def self.catalog_contains_resource(result, type, title)
     end
 
     it 'should not succeed' do
-      expect(@result.exitcode).to eq(-1), OctocatalogDiff::Integration.format_exception(@result)
+      expect(@result.exitcode).to eq(-1), @result.logs
     end
 
     it 'should raise ReferenceValidationError' do