In FactOverride object, key -> fact_name

Author: Kevin Paulisse

lib/octocatalog-diff/api/v1/fact_override.rb

@@ -8,14 +8,20 @@ module V1
       # Sets up the override of a fact during catalog compilation.
       class FactOverride
         # Accessors
-        attr_reader :key, :value
+        attr_reader :fact_name, :value
 
         # Constructor: Accepts a key and value.
-        # @param input [Hash] Must contain :key and :value
+        # @param input [Hash] Must contain :fact_name and :value
         def initialize(input)
-          @key = input.fetch(:key)
+          @fact_name = input.fetch(:fact_name)
           @value = input.fetch(:value)
         end
+
+        # Retrieve the fact_name as #key (essentially an alias)
+        # @return [String] Value of @fact_name
+        def key
+          @fact_name
+        end
       end
     end
   end

lib/octocatalog-diff/cli/fact_override.rb

@@ -27,12 +27,12 @@ def self.fact_override(input, key = nil)
           end
           key, raw_value = input.strip.split('=', 2)
           value = parsed_value(raw_value)
-          OctocatalogDiff::API::V1::FactOverride.new(key: key, value: value)
+          OctocatalogDiff::API::V1::FactOverride.new(fact_name: key, value: value)
         elsif key.nil?
           message = "Define a key when the input is not a string (#{input.class} => #{input.inspect})"
           raise ArgumentError, message
         else
-          OctocatalogDiff::API::V1::FactOverride.new(key: key, value: input)
+          OctocatalogDiff::API::V1::FactOverride.new(fact_name: key, value: input)
         end
       end
 

spec/octocatalog-diff/tests/api/v1/fact_override_spec.rb

@@ -6,25 +6,32 @@
 
 describe OctocatalogDiff::API::V1::FactOverride do
   describe '#new' do
-    it 'should raise error if key is not supplied' do
-      expect { described_class.new(value: 'bar') }.to raise_error(KeyError, /key/)
+    it 'should raise error if fact_name is not supplied' do
+      expect { described_class.new(value: 'bar') }.to raise_error(KeyError, /fact_name/)
     end
 
     it 'should raise error if value is not supplied' do
-      expect { described_class.new(key: 'bar') }.to raise_error(KeyError, /value/)
+      expect { described_class.new(fact_name: 'bar') }.to raise_error(KeyError, /value/)
+    end
+  end
+
+  describe '#fact_name' do
+    it 'should return fact_name' do
+      testobj = described_class.new(fact_name: 'foo', value: 'bar')
+      expect(testobj.fact_name).to eq('foo')
     end
   end
 
   describe '#key' do
-    it 'should return key' do
-      testobj = described_class.new(key: 'foo', value: 'bar')
+    it 'should return fact_name' do
+      testobj = described_class.new(fact_name: 'foo', value: 'bar')
       expect(testobj.key).to eq('foo')
     end
   end
 
   describe '#value' do
     it 'should return value' do
-      testobj = described_class.new(key: 'foo', value: 'bar')
+      testobj = described_class.new(fact_name: 'foo', value: 'bar')
       expect(testobj.value).to eq('bar')
     end
   end