Create a node guessing method

Author: kpaulisse

lib/octocatalog-diff/facts.rb

@@ -41,6 +41,15 @@ def dup
       self.class.new(@options, @orig_facts)
     end
 
+    # Node - get the node name, either as set explicitly or as determined from the facts themselves.
+    # @return [String] Node name, explicit or guessed
+    def node
+      return @node unless @node.nil? || @node.empty?
+      return facts['name'] if facts.key?('name')
+      return facts['values']['fqdn'] if facts.key?('values') && facts['values'].key?('fqdn')
+      ''
+    end
+
     # Facts - returned the 'cleansed' facts.
     # Clean up facts by setting 'name' to the node if given, and deleting _timestamp and expiration
     # which may cause Puppet catalog compilation to fail if the facts are old.

spec/octocatalog-diff/tests/facts_spec.rb

@@ -80,6 +80,32 @@
     end
   end
 
+  describe '#node' do
+    let(:opts) { { backend: :yaml, fact_file_string: File.read(OctocatalogDiff::Spec.fixture_path('facts/facts.yaml')) } }
+
+    it 'should return the node if set explicitly' do
+      obj = OctocatalogDiff::Facts.new(opts.merge(node: 'fluffy-kittens.example.com'))
+      expect(obj.node).to eq('fluffy-kittens.example.com')
+    end
+
+    it 'should return the node from the facts name in the fact file' do
+      obj = OctocatalogDiff::Facts.new(opts)
+      expect(obj.node).to eq('rspec-node.xyz.github.net')
+    end
+
+    it 'should return the FQDN' do
+      obj = OctocatalogDiff::Facts.new(opts)
+      allow(obj).to receive(:facts).and_return('values' => { 'fqdn' => 'foobar.example.com' })
+      expect(obj.node).to eq('foobar.example.com')
+    end
+
+    it 'should return empty if all else fails' do
+      obj = OctocatalogDiff::Facts.new(opts)
+      allow(obj).to receive(:facts).and_return({})
+      expect(obj.node).to eq('')
+    end
+  end
+
   context 'test individual methods' do
     before(:all) do
       opts = {