Make raise_exception default to false for parallel run tasks

Author: kpaulisse

lib/octocatalog-diff/util/catalogs.rb

@@ -89,7 +89,7 @@ def build_catalog_parallelizer
 
         # Execute the parallelized catalog builds
         passed_catalog_tasks = catalog_tasks.map { |x| x[1] }
-        parallel_catalogs = OctocatalogDiff::Util::Parallel.run_tasks(passed_catalog_tasks, @logger, @options[:parallel], false)
+        parallel_catalogs = OctocatalogDiff::Util::Parallel.run_tasks(passed_catalog_tasks, @logger, @options[:parallel])
 
         # If the catalogs array is empty at this point, there is an unexpected size mismatch. This should
         # never happen, but test for it anyway.

lib/octocatalog-diff/util/parallel.rb

@@ -62,7 +62,7 @@ def initialize(opts = {})
       #
       # Note: Parallelization throws intermittent errors under travis CI, so it will be disabled by
       # default for integration tests.
-      def self.run_tasks(task_array, logger = nil, parallelized = true, raise_exception = true)
+      def self.run_tasks(task_array, logger = nil, parallelized = true, raise_exception = false)
         # Create a throwaway logger object if one is not given
         logger ||= Logger.new(StringIO.new)
 

spec/octocatalog-diff/tests/util/parallel_spec.rb

@@ -69,7 +69,7 @@ def two(_arg, _logger = nil)
       c = Foo.new
       one = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:one), args: 'abc', description: 'test1')
       two = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:two), args: 'def', description: 'test2')
-      result = OctocatalogDiff::Util::Parallel.run_tasks([one, two], nil, true, false)
+      result = OctocatalogDiff::Util::Parallel.run_tasks([one, two], nil, true)
       expect(result).to be_a_kind_of(Array)
       expect(result.size).to eq(2)
 
@@ -102,7 +102,7 @@ def two(_arg, _logger = nil)
       c = Foo.new
       one = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:one), args: 'abc', description: 'test1')
       two = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:two), args: 'def', description: 'test2')
-      result = OctocatalogDiff::Util::Parallel.run_tasks([one, two], nil, true, false)
+      result = OctocatalogDiff::Util::Parallel.run_tasks([one, two], nil, true)
       expect(result).to be_a_kind_of(Array)
       expect(result.size).to eq(2)
 
@@ -133,12 +133,12 @@ def my_method(arg, _logger = nil)
       one = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:my_method), args: 'abc', description: 'test1')
       expect do
         logger = Logger.new(STDERR)
-        OctocatalogDiff::Util::Parallel.run_tasks([one], logger, true, false)
+        OctocatalogDiff::Util::Parallel.run_tasks([one], logger, true)
       end.to output(/DEBUG.*Begin test1/).to_stderr_from_any_process
 
       expect do
         logger = Logger.new(STDERR)
-        OctocatalogDiff::Util::Parallel.run_tasks([one], logger, true, false)
+        OctocatalogDiff::Util::Parallel.run_tasks([one], logger, true)
       end.to output(/DEBUG.*Success test1/).to_stderr_from_any_process
     end
 
@@ -154,12 +154,12 @@ def my_method(arg, _logger = nil)
       two = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:my_method), args: 'def', description: 'test2')
       expect do
         logger = Logger.new(STDERR)
-        OctocatalogDiff::Util::Parallel.run_tasks([one, two], logger, true, false)
+        OctocatalogDiff::Util::Parallel.run_tasks([one, two], logger, true)
       end.to output(/DEBUG.*Begin test[12]/).to_stderr_from_any_process
 
       expect do
         logger = Logger.new(STDERR)
-        OctocatalogDiff::Util::Parallel.run_tasks([one, two], logger, true, false)
+        OctocatalogDiff::Util::Parallel.run_tasks([one, two], logger, true)
       end.to output(/DEBUG.*Failed test[12]: RuntimeError (abc|def)/).to_stderr_from_any_process
     end
 
@@ -215,7 +215,7 @@ def validate(arg, _logger = nil, _extra_args = {})
       v = c.method(:validate)
       one = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:one), args: 'abc', description: 'test1', validator: v)
       two = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:two), args: 'def', description: 'test2', validator: v)
-      result = OctocatalogDiff::Util::Parallel.run_tasks([one, two], nil, true, false)
+      result = OctocatalogDiff::Util::Parallel.run_tasks([one, two], nil, true)
       expect(result).to be_a_kind_of(Array)
       expect(result.size).to eq(2)
 
@@ -243,7 +243,7 @@ def validate(arg, _logger = nil, _extra_args = {})
       v = c.method(:validate)
       one = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:one), args: 'abc', description: 'test1', validator: v)
       two = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:two), args: 'def', description: 'test2', validator: v)
-      result = OctocatalogDiff::Util::Parallel.run_tasks([one, two], nil, true, false)
+      result = OctocatalogDiff::Util::Parallel.run_tasks([one, two], nil, true)
       expect(result).to be_a_kind_of(Array)
       expect(result.size).to eq(2)
 
@@ -303,7 +303,7 @@ def two(_arg, _logger = nil)
       c = Foo.new
       one = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:one), args: 'abc', description: 'test1')
       two = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:two), args: 'def', description: 'test2')
-      result = OctocatalogDiff::Util::Parallel.run_tasks([one, two], nil, false, false)
+      result = OctocatalogDiff::Util::Parallel.run_tasks([one, two], nil, false)
       expect(result).to be_a_kind_of(Array)
       expect(result.size).to eq(2)
 
@@ -334,7 +334,7 @@ def two(arg, _logger = nil)
       c = Foo.new
       one = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:one), args: 'abc', description: 'test1')
       two = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:two), args: 'def', description: 'test2')
-      result = OctocatalogDiff::Util::Parallel.run_tasks([one, two], nil, false, false)
+      result = OctocatalogDiff::Util::Parallel.run_tasks([one, two], nil, false)
       expect(result).to be_a_kind_of(Array)
       expect(result.size).to eq(2)
 
@@ -378,7 +378,7 @@ def my_method(arg, _logger = nil)
       one = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:my_method), args: 'abc', description: 'test1')
       two = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:my_method), args: 'def', description: 'test2')
       logger, logger_string = OctocatalogDiff::Spec.setup_logger
-      OctocatalogDiff::Util::Parallel.run_tasks([one, two], logger, false, false)
+      OctocatalogDiff::Util::Parallel.run_tasks([one, two], logger, false)
       expect(logger_string.string).to match(/DEBUG.*Begin test1/)
       expect(logger_string.string).to match(/DEBUG.*Failed test1: RuntimeError abc/)
     end
@@ -407,7 +407,7 @@ def validate(arg, _logger = nil, _extra_args = {})
       v = c.method(:validate)
       one = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:one), args: 'abc', description: 'test1', validator: v)
       two = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:two), args: 'def', description: 'test2', validator: v)
-      result = OctocatalogDiff::Util::Parallel.run_tasks([one, two], nil, false)
+      result = OctocatalogDiff::Util::Parallel.run_tasks([one, two], nil)
       expect(result).to be_a_kind_of(Array)
       expect(result.size).to eq(2)
 
@@ -434,7 +434,7 @@ def validate(arg, _logger = nil, _extra_args = {})
       v = c.method(:validate)
       one = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:one), args: 'abc', description: 'test1', validator: v)
       two = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:two), args: 'def', description: 'test2', validator: v)
-      result = OctocatalogDiff::Util::Parallel.run_tasks([one, two], nil, false, false)
+      result = OctocatalogDiff::Util::Parallel.run_tasks([one, two], nil, false)
       expect(result).to be_a_kind_of(Array)
       expect(result.size).to eq(2)
 
@@ -461,7 +461,7 @@ def validate(arg, _logger = nil, _extra_args = {})
       v = c.method(:validate)
       one = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:one), args: 'abc', description: 'test1', validator: v)
       two = OctocatalogDiff::Util::Parallel::Task.new(method: c.method(:two), args: 'def', description: 'test2', validator: v)
-      result = OctocatalogDiff::Util::Parallel.run_tasks([one, two], nil, false, false)
+      result = OctocatalogDiff::Util::Parallel.run_tasks([one, two], nil, false)
       expect(result).to be_a_kind_of(Array)
       expect(result.size).to eq(2)