Support catalog saving

Author: kpaulisse

lib/octocatalog-diff/util/catalogs.rb

@@ -197,6 +197,11 @@ def add_parallel_result(result, parallel_catalog_obj, key_task_tuple)
           if catalog.valid?
             # The catalog was successfully compiled.
             result[key] = parallel_catalog_obj.output
+
+            if task.args[:save_catalog]
+              File.open(task.args[:save_catalog], 'w') { |f| f.write(catalog.catalog_json) }
+              @logger.debug "Saved catalog to #{task.args[:save_catalog]}"
+            end
           else
             # The catalog failed, but a catalog object was returned so that better error reporting
             # can take place. In this error reporting, we will replace 'Error:' with '[Puppet Error]'

spec/octocatalog-diff/tests/util/catalogs_spec.rb

@@ -330,6 +330,27 @@ def valid?
       expect(result[:from]).to eq('blank')
     end
 
+    context 'saving the catalog' do
+      before(:each) { @tmpdir = Dir.mktmpdir }
+      after(:each) { OctocatalogDiff::Spec.clean_up_tmpdir(@tmpdir) }
+
+      it 'should save the catalog when requested' do
+        filename = File.join(@tmpdir, 'catalog.json')
+        options = {
+          to_catalog: OctocatalogDiff::Spec.fixture_path('catalogs/tiny-catalog.json'),
+          from_catalog: OctocatalogDiff::Spec.fixture_path('catalogs/catalog-test-file.json'),
+          from_save_catalog: filename
+        }
+
+        logger, logger_str = OctocatalogDiff::Spec.setup_logger
+        testobj = OctocatalogDiff::Util::Catalogs.new(options, logger)
+        result = testobj.send(:build_catalog_parallelizer)
+
+        expect(logger_str.string).to match(Regexp.escape("Saved catalog to #{filename}"))
+        expect(File.read(filename)).to eq(result[:from].catalog_json)
+      end
+    end
+
     it 'should format error and raise error when a catalog compile fails' do
       error_lines = [
         'Debug: You do not care about this',