Delete logger, don't nil it

Author: Kevin Paulisse

lib/octocatalog-diff/api/v1/common.rb

@@ -12,7 +12,8 @@ def self.logger_from_options(options)
           logger = options[:logger] || Logger.new(StringIO.new)
 
           # We can't keep :logger in the options due to marshal/unmarshal as part of parallelization.
-          pass_opts = options.merge(logger: nil)
+          pass_opts = options.dup
+          pass_opts.delete(:logger)
 
           # Return cleaned options and logger
           [pass_opts, logger]

spec/octocatalog-diff/tests/api/v1/common_spec.rb

@@ -13,21 +13,21 @@
       options = { logger: logger, foo: 'bar' }
       result_opts, result_logger = described_class.logger_from_options(options)
       expect(result_logger).to eq(logger)
-      expect(result_opts).to eq(foo: 'bar', logger: nil)
+      expect(result_opts).to eq(foo: 'bar')
     end
 
     it 'should construct a logger if one is not passed in' do
       result_opts, result_logger = described_class.logger_from_options(foo: 'bar')
       expect(result_logger).to be_a_kind_of(Logger)
-      expect(result_opts).to eq(foo: 'bar', logger: nil)
+      expect(result_opts).to eq(foo: 'bar')
     end
 
     it 'should remove logger from options passed to catalogs class' do
       logger, _logger_str = OctocatalogDiff::Spec.setup_logger
       options = { foo: 'bar', logger: logger }
       result_opts, result_logger = described_class.logger_from_options(options)
       expect(result_opts[:foo]).to eq('bar')
-      expect(result_opts[:logger]).to be_nil
+      expect(result_opts.key?(:logger)).to eq(false)
       expect(result_logger).to eq(logger)
     end
   end