Add --hiera_path command line argument

Author: Kevin Paulisse

lib/octocatalog-diff/catalog-diff/cli/options/hiera_path.rb

@@ -0,0 +1,20 @@
+# Specify the path to the Hiera data directory (relative to the top level Puppet checkout). For Puppet Enterprise and the
+# Puppet control repo template, the value of this should be 'hieradata', which is the default.
+# @param parser [OptionParser object] The OptionParser argument
+# @param options [Hash] Options hash being constructed; this is modified in this method.
+OctocatalogDiff::CatalogDiff::Cli::Options::Option.newoption(:hiera_path) do
+  has_weight 181
+
+  def parse(parser, options)
+    parser.on('--hiera-path PATH', 'Path to hiera data directory, relative to top directory of repository') do |path_in|
+      options[:hiera_path] = path_in
+
+      if options[:hiera_path].start_with?('/')
+        raise ArgumentError, '--hiera-path PATH must be a relative path not an absolute path'
+      end
+
+      options[:hiera_path].sub!(%r{/+$}, '')
+      raise ArgumentError, '--hiera-path must not be empty' if options[:hiera_path].empty?
+    end
+  end
+end

lib/octocatalog-diff/catalog-diff/cli/options/hiera_path_strip.rb

@@ -2,7 +2,7 @@
 # @param parser [OptionParser object] The OptionParser argument
 # @param options [Hash] Options hash being constructed; this is modified in this method.
 OctocatalogDiff::CatalogDiff::Cli::Options::Option.newoption(:hiera_path_strip) do
-  has_weight 181
+  has_weight 182
 
   def parse(parser, options)
     parser.on('--hiera-path-strip PATH', 'Path prefix to strip when munging hiera.yaml') do |path_in|

spec/octocatalog-diff/tests/catalog-diff/cli/options/hiera_path_spec.rb

@@ -0,0 +1,23 @@
+require_relative '../options_helper'
+
+describe OctocatalogDiff::CatalogDiff::Cli::Options do
+  describe '#opt_hiera_path' do
+    it 'should set options[:hiera_path] when relative path is specified' do
+      result = run_optparse(['--hiera-path', 'foo/bar/baz'])
+      expect(result.fetch(:hiera_path, 'key-not-defined')).to eq('foo/bar/baz')
+    end
+
+    it 'should error if an absolute path is specified' do
+      expect { run_optparse(['--hiera-path', '/foo/bar/baz']) }.to raise_error(ArgumentError, /must be a relative path/)
+    end
+
+    it 'should strip trailing slashes' do
+      result = run_optparse(['--hiera-path', 'foo/bar/baz///'])
+      expect(result.fetch(:hiera_path, 'key-not-defined')).to eq('foo/bar/baz')
+    end
+
+    it 'should error if empty' do
+      expect { run_optparse(['--hiera-path', '']) }.to raise_error(ArgumentError, /must not be empty/)
+    end
+  end
+end