Add filter validation to --filters option

Author: Kevin Paulisse

lib/octocatalog-diff/cli/options/filters.rb

@@ -12,6 +12,9 @@ def parse(parser, options)
     parser.on('--filters FILTER1[,FILTER2[,...]]', Array, 'Filters to apply') do |x|
       options[:filters] ||= []
       options[:filters].concat x
+
+      require_relative '../../catalog-diff/filter'
+      options[:filters].each { |filter| OctocatalogDiff::CatalogDiff::Filter.assert_that_filter_exists(filter) }
     end
   end
 end

spec/octocatalog-diff/tests/cli/options/filters_spec.rb

@@ -5,13 +5,19 @@
 describe OctocatalogDiff::Cli::Options do
   describe '#opt_ignore_equivalent_yaml_files' do
     it 'should accept comma delimited parameters for --filters' do
-      result = run_optparse(['--filters', 'fizzbuzz,barbuzz'])
-      expect(result[:filters]).to eq(%w(fizzbuzz barbuzz))
+      result = run_optparse(['--filters', 'AbsentFile,YAML'])
+      expect(result[:filters]).to eq(%w(AbsentFile YAML))
     end
 
     it 'should accept multiple parameters for --filters' do
-      result = run_optparse(['--filters', 'fizzbuzz', '--filters', 'barbuzz'])
-      expect(result[:filters]).to eq(%w(fizzbuzz barbuzz))
+      result = run_optparse(['--filters', 'AbsentFile', '--filters', 'YAML'])
+      expect(result[:filters]).to eq(%w(AbsentFile YAML))
+    end
+
+    it 'should raise ArgumentError if invalid filter is specified' do
+      expect do
+        run_optparse(['--filters', 'AbsentFile,FizzBuzzDoesNotExist,YAML'])
+      end.to raise_error(ArgumentError, 'The filter FizzBuzzDoesNotExist is not valid')
     end
   end
 end