Fixnum -> integer for fact overrides

Author: Kevin Paulisse

lib/octocatalog-diff/api/v1/override.rb

@@ -72,9 +72,9 @@ def convert_to_data_type(datatype, value)
           return value if datatype == 'string'
           return parse_json(value) if datatype == 'json'
           return nil if datatype == 'nil'
-          if datatype == 'fixnum'
+          if datatype == 'fixnum' || datatype == 'integer'
             return Regexp.last_match(1).to_i if value =~ /^(-?\d+)$/
-            raise ArgumentError, "Illegal fixnum '#{value}'"
+            raise ArgumentError, "Illegal integer '#{value}'"
           end
           if datatype == 'float'
             return Regexp.last_match(1).to_f if value =~ /^(-?\d*\.\d+)$/

spec/octocatalog-diff/integration/fact_override_spec.rb

@@ -134,24 +134,24 @@
       pending 'catalog-diff failed' unless @result[:exitcode] == 2 && @diffs.size == 1
       file = @diffs[0][2].split(/\n/)
       expect(file).to include('my_boolean: TrueClass true')
-      expect(file).to include('my_integer: Fixnum 42')
+      expect(file).to include('my_integer: Integer 42')
       expect(file).to include('my_float: Float 3.14159')
-      expect(file).to include('my_floating_integer: Fixnum -100')
+      expect(file).to include('my_floating_integer: Integer -100')
       expect(file).to include('my_json: String "{\\"hello\\":\\"world\\"}"')
       expect(file).to include('my_boolean_string: FalseClass false')
-      expect(file).to include('my_integer_string: Fixnum 42')
+      expect(file).to include('my_integer_string: Integer 42')
       expect(file).to include('my_float_string: Float 3.14159')
       expect(file).to include('real_boolean: FalseClass false')
       expect(file).to include('real_float: Float 3.14159')
-      expect(file).to include('real_integer: Fixnum 42')
+      expect(file).to include('real_integer: Integer 42')
       expect(file).to include('real_string: String "chicken"')
     end
 
     it 'should show the specified data types in the new catalog' do
       pending 'catalog-diff failed' unless @result[:exitcode] == 2 && @diffs.size == 1
       file = @diffs[0][3].split(/\n/)
       expect(file).to include('my_boolean: TrueClass true')
-      expect(file).to include('my_integer: Fixnum 42')
+      expect(file).to include('my_integer: Integer 42')
       expect(file).to include('my_float: Float 3.14159')
       expect(file).to include('my_floating_integer: Float -100.0')
       expect(file).to include('my_json: Hash {"hello"=>"world"}')
@@ -160,7 +160,7 @@
       expect(file).to include('my_float_string: String "3.14159"')
       expect(file).to include('real_boolean: FalseClass false')
       expect(file).to include('real_float: Float 3.14159')
-      expect(file).to include('real_integer: Fixnum 42')
+      expect(file).to include('real_integer: Integer 42')
       expect(file).to include('real_string: String "chicken"')
     end
   end