Allow override '/text/' to construct a regexp

Author: kpaulisse

lib/octocatalog-diff/api/v1/override.rb

@@ -13,7 +13,8 @@ class Override
         # Constructor: Accepts a key and value.
         # @param input [Hash] Must contain :key and :value
         def initialize(input)
-          @key = input.fetch(:key)
+          key = input.fetch(:key)
+          @key = key =~ %r{\A/(.+)/\Z} ? Regexp.new(Regexp.last_match(1)) : key
           @value = parsed_value(input.fetch(:value))
         end
 
@@ -29,6 +30,7 @@ def self.create_from_input(input, key = nil)
           # If input is not a string, we can still construct the object if the key is given.
           # That input would come directly from code and not from the command line, since inputs
           # from the command line are always strings.
+          # Also support regular expressions for the key name, if delimited by //.
           if key.nil? && input.is_a?(String)
             unless input.include?('=')
               raise ArgumentError, "Fact override '#{input}' is not in 'key=(data type)value' format"

spec/octocatalog-diff/tests/api/v1/override_spec.rb

@@ -6,13 +6,19 @@
 
 describe OctocatalogDiff::API::V1::Override do
   describe '#new' do
-    it 'should raise error if fact_name is not supplied' do
+    it 'should raise error if fact name is not supplied' do
       expect { described_class.new(value: 'bar') }.to raise_error(KeyError, /key/)
     end
 
     it 'should raise error if value is not supplied' do
       expect { described_class.new(key: 'bar') }.to raise_error(KeyError, /value/)
     end
+
+    it 'should return a regexp if fact name is a regexp' do
+      testobj = described_class.new(key: '/foo/', value: 'bar')
+      expect(testobj.key).to eq(/foo/)
+      expect(testobj.value).to eq('bar')
+    end
   end
 
   describe '#key' do