Create hiera5 integration test

Author: kpaulisse

spec/octocatalog-diff/fixtures/repos/hiera5/config/hiera5-global.yaml

@@ -1,16 +1,16 @@
 ---
 version: 5
 defaults:
-  datadir: hieradata
+  datadir: /var/lib/puppet/environments/%{::environment}/hieradata
   data_hash: yaml_data
 
 hierarchy:
   - name: "Default structure data"
-    path: "nodes/%{app}.yaml"
+    path: "nodes/%{::fqdn}.yaml"
 
   - name: "Special data"
-    path: "%{app}.yaml"
-    datadir: "special"
+    path: "%{::datacenter}.yaml"
+    datadir: /var/lib/puppet/environments/%{::environment}/special
 
   - name: "Common data"
     path: "common.yaml"

spec/octocatalog-diff/fixtures/repos/hiera5/hieradata/common.yaml

@@ -0,0 +1,4 @@
+---
+test::param_from_node: Should not be displayed from common
+test::param_from_special: Should not be displayed from common
+test::param_from_common: Greets from common

spec/octocatalog-diff/fixtures/repos/hiera5/hieradata/nodes/rspec-node.xyz.github.net.yaml

@@ -0,0 +1,2 @@
+---
+test::param_from_nodes: Greets from nodes

spec/octocatalog-diff/fixtures/repos/hiera5/hieradata/xyz.yaml

@@ -0,0 +1,2 @@
+---
+test::param_from_special: This should never be displayed!

spec/octocatalog-diff/fixtures/repos/hiera5/manifests/site.pp

@@ -0,0 +1,3 @@
+node default {
+  include test
+}

spec/octocatalog-diff/fixtures/repos/hiera5/modules/test/manifests/init.pp

@@ -0,0 +1,9 @@
+class test (
+  String $param_from_nodes   = 'hard-coded',
+  String $param_from_special = 'hard-coded',
+  String $param_from_common  = 'hard-coded'
+) {
+  file { '/tmp/nodes': content => $param_from_nodes }
+  file { '/tmp/special': content => $param_from_special }
+  file { '/tmp/common': content => $param_from_common }
+}

spec/octocatalog-diff/fixtures/repos/hiera5/special/xyz.yaml

@@ -0,0 +1,2 @@
+---
+test::param_from_special: Greets from special

spec/octocatalog-diff/integration/hiera5_spec.rb

@@ -6,11 +6,41 @@
   context 'with --hiera-path and per-item data directory' do
     it 'should fail because per-item datadir is not supported with --hiera-path' do
       argv = ['-n', 'rspec-node.github.net']
-      hash = { hiera_config: 'config/hiera5-global.yaml', spec_fact_file: 'facts.yaml', spec_repo: 'hiera5' }
+      hash = {
+        hiera_config: 'config/hiera5-global.yaml',
+        spec_fact_file: 'facts.yaml',
+        spec_repo: 'hiera5',
+        spec_catalog_old: 'catalog-empty.json'
+      }
       result = OctocatalogDiff::Integration.integration(hash.merge(argv: argv))
       expect(result.exitcode).to eq(-1), OctocatalogDiff::Integration.format_exception(result)
       expect(result.exception).to be_a_kind_of(ArgumentError)
       expect(result.exception.message).to match(/Hierarchy item .+ has a datadir/)
     end
   end
+
+  context 'with --hiera-path-strip and per-item data directory' do
+    it 'should succeed in building the catalog' do
+      argv = ['-n', 'rspec-node.github.net', '--hiera-path-strip', '/var/lib/puppet']
+      hash = {
+        hiera_config: 'config/hiera5-global.yaml',
+        spec_fact_file: 'facts.yaml',
+        spec_repo: 'hiera5',
+        spec_catalog_old: 'catalog-empty.json'
+      }
+      result = OctocatalogDiff::Integration.integration(hash.merge(argv: argv))
+      expect(result.exitcode).to eq(2), OctocatalogDiff::Integration.format_exception(result)
+
+      to_catalog = result.to
+
+      param1 = { 'content' => 'Greets from nodes' }
+      expect(to_catalog.resource(type: 'File', title: '/tmp/nodes')['parameters']).to eq(param1)
+
+      param2 = { 'content' => 'Greets from special' }
+      expect(to_catalog.resource(type: 'File', title: '/tmp/special')['parameters']).to eq(param2)
+
+      param3 = { 'content' => 'Greets from common' }
+      expect(to_catalog.resource(type: 'File', title: '/tmp/common')['parameters']).to eq(param3)
+    end
+  end
 end