Create safe_dup method and set facts to use it

Author: kpaulisse

lib/octocatalog-diff/facts.rb

@@ -4,6 +4,7 @@
 require_relative 'facts/json'
 require_relative 'facts/yaml'
 require_relative 'facts/puppetdb'
+require_relative 'util/util'
 require_relative 'external/pson/pure'
 
 module OctocatalogDiff
@@ -17,10 +18,10 @@ class Facts
     def initialize(options = {}, facts = nil)
       @node = options.fetch(:node, '')
       @timestamp = false
-      @options = options.dup
+      @options = OctocatalogDiff::Util::Util.safe_dup(options)
       if facts
         @facts = {}
-        facts.each { |k, v| @facts[k] = v.dup }
+        facts.each { |k, v| @facts[k] = OctocatalogDiff::Util::Util.safe_dup(v) }
       else
         case options[:backend]
         when :json
@@ -33,7 +34,7 @@ def initialize(options = {}, facts = nil)
           raise ArgumentError, 'Invalid fact source backend'
         end
         @facts = {}
-        @orig_facts.each { |k, v| @facts[k] = v.dup }
+        @orig_facts.each { |k, v| @facts[k] = OctocatalogDiff::Util::Util.safe_dup(v) }
       end
     end
 

lib/octocatalog-diff/util/util.rb

@@ -16,6 +16,15 @@ def self.object_is_any_of?(object, classes)
         classes.each { |clazz| return true if object.is_a? clazz }
         false
       end
+
+      # Utility Method!
+      # `.dup` can't be called on certain objects (Fixnum for example). This
+      # method returns the original object if it can't be duplicated.
+      def self.safe_dup(object)
+        object.dup
+      rescue TypeError
+        object
+      end
     end
   end
 end

spec/octocatalog-diff/tests/util/util_spec.rb

@@ -18,4 +18,44 @@
       expect(described_class.object_is_any_of?(object, classes)).to eq(false)
     end
   end
+
+  describe '#safe_dup' do
+    it 'should work with nil' do
+      object = nil
+      result = described_class.safe_dup(object)
+      expect(object).to eq(result)
+    end
+
+    it 'should work with a string' do
+      object = 'boots and cats'
+      result = described_class.safe_dup(object)
+      expect(object).to eq(result)
+    end
+
+    it 'should work with a symbol' do
+      object = :chickens
+      result = described_class.safe_dup(object)
+      expect(object).to eq(result)
+    end
+
+    it 'should work with an integer' do
+      object = 42
+      result = described_class.safe_dup(object)
+      expect(object).to eq(result)
+    end
+
+    it 'should work with a hash' do
+      object = { 'foo' => 'bar', 'baz' => 'buzz' }
+      result = described_class.safe_dup(object)
+      expect(object).to eq(result)
+      expect(object.object_id).not_to eq(result.object_id)
+    end
+
+    it 'should work with an array' do
+      object = %w[foo bar baz buzz]
+      result = described_class.safe_dup(object)
+      expect(object).to eq(result)
+      expect(object.object_id).not_to eq(result.object_id)
+    end
+  end
 end