Validator returns true

Author: kpaulisse

lib/octocatalog-diff/util/catalogs.rb

@@ -234,7 +234,7 @@ def build_catalog(opts, logger = @logger)
       def catalog_validator(catalog = nil, _logger = @logger, args = {})
         return false unless catalog.is_a?(OctocatalogDiff::Catalog)
         catalog.validate_references if args[:task] == :to
-        return if catalog.valid?
+        return true if catalog.valid?
         raise OctocatalogDiff::Errors::CatalogError, 'Catalog failed: Invalid catalog'
       end
     end

lib/octocatalog-diff/util/parallel.rb

@@ -170,15 +170,13 @@ def self.execute_task(task, logger)
           result = Result.new(output: output, status: true, args: task.args)
         rescue => exc
           logger.debug("Failed #{task.description}: #{exc.class} #{exc.message}")
-          result = Result.new(exception: exc, status: false, args: task.args)
+          return Result.new(exception: exc, status: false, args: task.args)
         end
 
         begin
-          successful_validation = task.validate(output, logger)
-          if successful_validation
+          if task.validate(output, logger)
             logger.debug("Success #{task.description}")
           else
-            logger.warn("Failed #{task.description} validation")
             raise "Failed #{task.description} validation (unspecified error)"
           end
         rescue => exc