Merge pull request #26 from github/kpaulisse-frozen-string-literal

Frozen string literals

Author: kpaulisse

lib/octocatalog-diff/bootstrap.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'open3'
 require 'shellwords'
 

lib/octocatalog-diff/catalog-diff/cli.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'cli/catalogs'
 require_relative 'cli/diffs'
 require_relative 'cli/options'

lib/octocatalog-diff/catalog-diff/cli/catalogs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require 'open3'
 require 'yaml'

lib/octocatalog-diff/catalog-diff/cli/diffs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../differ'
 
 module OctocatalogDiff

lib/octocatalog-diff/catalog-diff/cli/helpers/fact_override.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 
 module OctocatalogDiff
@@ -26,8 +28,7 @@ def initialize(input, key = nil)
               unless input.include?('=')
                 raise ArgumentError, "Fact override '#{input}' is not in 'key=(data type)value' format"
               end
-              input.strip!
-              @key, raw_value = input.split('=', 2)
+              @key, raw_value = input.strip.split('=', 2)
               @value = parsed_value(raw_value)
             elsif key.nil?
               message = "Define a key when the input is not a string (#{input.class} => #{input.inspect})"

lib/octocatalog-diff/catalog-diff/cli/options.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../cli'
 require_relative '../../facts'
 require_relative '../../version'

lib/octocatalog-diff/catalog-diff/cli/options/basedir.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Option to set the base checkout directory of puppet repository
 # @param parser [OptionParser object] The OptionParser argument
 # @param options [Hash] Options hash being constructed; this is modified in this method.

lib/octocatalog-diff/catalog-diff/cli/options/bootstrap_current.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Option to bootstrap the current directory (by default, the bootstrap script is NOT
 # run when the catalog builds in the current directory).
 # @param parser [OptionParser object] The OptionParser argument

lib/octocatalog-diff/catalog-diff/cli/options/bootstrap_environment.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Allow the bootstrap environment to be set up via the command line.
 # @param parser [OptionParser object] The OptionParser argument
 # @param options [Hash] Options hash being constructed; this is modified in this method.

lib/octocatalog-diff/catalog-diff/cli/options/bootstrap_script.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Allow specification of a bootstrap script. This runs after checking out the directory, and before running
 # puppet there. Good for running librarian to install modules, and anything else site-specific that needs
 # to be done.