Merge pull request #481 from github/autocommit

Shlomi Noach · web-flow · commit ed0fc1c7b91d · 2017-09-03T07:58:57.000+03:00
gh-ost uses autocommit=1 for all connections
diff --git a/go/mysql/connection.go b/go/mysql/connection.go
@@ -56,5 +56,5 @@ func (this *ConnectionConfig) GetDBUri(databaseName string) string {
 		// Wrap IPv6 literals in square brackets
 		hostname = fmt.Sprintf("[%s]", hostname)
 	}
-	return fmt.Sprintf("%s:%s@tcp(%s:%d)/%s?interpolateParams=true&charset=utf8mb4,utf8,latin1", this.User, this.Password, hostname, this.Key.Port, databaseName)
+	return fmt.Sprintf("%s:%s@tcp(%s:%d)/%s?interpolateParams=true&autocommit=true&charset=utf8mb4,utf8,latin1", this.User, this.Password, hostname, this.Key.Port, databaseName)
 }

Original file line number	Diff line number	Diff line change
`@@ -56,5 +56,5 @@ func (this *ConnectionConfig) GetDBUri(databaseName string) string {`
`56`	`56`	`// Wrap IPv6 literals in square brackets`
`57`	`57`	`hostname = fmt.Sprintf("[%s]", hostname)`
`58`	`58`	`}`
`59`		`- return fmt.Sprintf("%s:%s@tcp(%s:%d)/%s?interpolateParams=true&charset=utf8mb4,utf8,latin1", this.User, this.Password, hostname, this.Key.Port, databaseName)`
	`59`	`+ return fmt.Sprintf("%s:%s@tcp(%s:%d)/%s?interpolateParams=true&autocommit=true&charset=utf8mb4,utf8,latin1", this.User, this.Password, hostname, this.Key.Port, databaseName)`
`60`	`60`	`}`