Skip to content

Commit e82d563

Browse files
committed
Close the binlog syncer
1 parent ec6ceff commit e82d563

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

go/binlog/gomysql_reader.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -158,10 +158,6 @@ func (this *GoMySQLReader) StreamEvents(canStopStreaming func() bool, entriesCha
158158
}
159159

160160
func (this *GoMySQLReader) Close() error {
161-
// Historically there was a:
162-
// this.binlogSyncer.Close()
163-
// here. A new go-mysql version closes the binlog syncer connection independently.
164-
// I will go against the sacred rules of comments and just leave this here.
165-
// This is the year 2017. Let's see what year these comments get deleted.
161+
this.binlogSyncer.Close()
166162
return nil
167163
}

0 commit comments

Comments
 (0)