Skip to content

Commit b07de62

Browse files
committed
Update branch to match remote
2 parents dfb9f88 + d16fa02 commit b07de62

3 files changed

Lines changed: 24 additions & 5 deletions

File tree

.travis.yml

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,20 @@
1+
# http://docs.travis-ci.com/user/languages/go/
12
language: go
23

3-
go:
4-
- 1.6
5-
- tip
4+
go: 1.8
65

7-
script: ./test.sh
6+
os:
7+
- linux
8+
9+
env:
10+
- MYSQL_USER=root
11+
12+
before_install:
13+
- mysql -e 'CREATE DATABASE IF NOT EXISTS test;'
14+
15+
install: true
16+
17+
script: script/cibuild
18+
19+
notifications:
20+
email: false

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# gh-ost
22

3+
[![build status](https://travis-ci.org/github/gh-ost.svg)](https://travis-ci.org/github/gh-ost) [![downloads](https://img.shields.io/github/downloads/github/gh-ost/total.svg)](https://github.com/github/gh-ost/releases) [![release](https://img.shields.io/github/release/github/gh-ost.svg)](https://github.com/github/gh-ost/releases)
4+
35
#### GitHub's online schema migration for MySQL <img src="doc/images/gh-ost-logo-light-160.png" align="right">
46

57
`gh-ost` is a triggerless online schema migration solution for MySQL. It is testable and provides pausability, dynamic control/reconfiguration, auditing, and many operational perks.

go/binlog/gomysql_reader.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,10 @@ func (this *GoMySQLReader) StreamEvents(canStopStreaming func() bool, entriesCha
160160
}
161161

162162
func (this *GoMySQLReader) Close() error {
163-
this.binlogSyncer.Close()
163+
// Historically there was a:
164+
// this.binlogSyncer.Close()
165+
// here. A new go-mysql version closes the binlog syncer connection independently.
166+
// I will go against the sacred rules of comments and just leave this here.
167+
// This is the year 2017. Let's see what year these comments get deleted.
164168
return nil
165169
}

0 commit comments

Comments
 (0)