Merge pull request #458 from github/arthurnn/context_test

Arthur Nogueira Neves · web-flow · commit 6e51068c845c · 2017-07-25T09:45:59.000-07:00
Dont share the same context in the table name tests
diff --git a/go/base/context_test.go b/go/base/context_test.go
@@ -18,25 +18,28 @@ func init() {
 }
 
 func TestGetTableNames(t *testing.T) {
-	context = newMigrationContext()
 	{
+		context = newMigrationContext()
 		context.OriginalTableName = "some_table"
 		test.S(t).ExpectEquals(context.GetOldTableName(), "_some_table_del")
 		test.S(t).ExpectEquals(context.GetGhostTableName(), "_some_table_gho")
 		test.S(t).ExpectEquals(context.GetChangelogTableName(), "_some_table_ghc")
 	}
 	{
+		context = newMigrationContext()
 		context.OriginalTableName = "a123456789012345678901234567890123456789012345678901234567890"
 		test.S(t).ExpectEquals(context.GetOldTableName(), "_a1234567890123456789012345678901234567890123456789012345678_del")
 		test.S(t).ExpectEquals(context.GetGhostTableName(), "_a1234567890123456789012345678901234567890123456789012345678_gho")
 		test.S(t).ExpectEquals(context.GetChangelogTableName(), "_a1234567890123456789012345678901234567890123456789012345678_ghc")
 	}
 	{
+		context = newMigrationContext()
 		context.OriginalTableName = "a123456789012345678901234567890123456789012345678901234567890123"
 		oldTableName := context.GetOldTableName()
 		test.S(t).ExpectEquals(oldTableName, "_a1234567890123456789012345678901234567890123456789012345678_del")
 	}
 	{
+		context = newMigrationContext()
 		context.OriginalTableName = "a123456789012345678901234567890123456789012345678901234567890123"
 		context.TimestampOldTable = true
 		longForm := "Jan 2, 2006 at 3:04pm (MST)"
@@ -45,9 +48,9 @@ func TestGetTableNames(t *testing.T) {
 		test.S(t).ExpectEquals(oldTableName, "_a1234567890123456789012345678901234567890123_20130203195400_del")
 	}
 	{
+		context = newMigrationContext()
 		context.OriginalTableName = "foo_bar_baz"
 		context.ForceTmpTableName = "tmp"
-		context.TimestampOldTable = false
 		test.S(t).ExpectEquals(context.GetOldTableName(), "_tmp_del")
 		test.S(t).ExpectEquals(context.GetGhostTableName(), "_tmp_gho")
 		test.S(t).ExpectEquals(context.GetChangelogTableName(), "_tmp_ghc")

Original file line number	Diff line number	Diff line change
`@@ -18,25 +18,28 @@ func init() {`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`func TestGetTableNames(t *testing.T) {`
`21`		`- context = newMigrationContext()`
`22`	`21`	`{`
	`22`	`+ context = newMigrationContext()`
`23`	`23`	`context.OriginalTableName = "some_table"`
`24`	`24`	`test.S(t).ExpectEquals(context.GetOldTableName(), "_some_table_del")`
`25`	`25`	`test.S(t).ExpectEquals(context.GetGhostTableName(), "_some_table_gho")`
`26`	`26`	`test.S(t).ExpectEquals(context.GetChangelogTableName(), "_some_table_ghc")`
`27`	`27`	`}`
`28`	`28`	`{`
	`29`	`+ context = newMigrationContext()`
`29`	`30`	`context.OriginalTableName = "a123456789012345678901234567890123456789012345678901234567890"`
`30`	`31`	`test.S(t).ExpectEquals(context.GetOldTableName(), "_a1234567890123456789012345678901234567890123456789012345678_del")`
`31`	`32`	`test.S(t).ExpectEquals(context.GetGhostTableName(), "_a1234567890123456789012345678901234567890123456789012345678_gho")`
`32`	`33`	`test.S(t).ExpectEquals(context.GetChangelogTableName(), "_a1234567890123456789012345678901234567890123456789012345678_ghc")`
`33`	`34`	`}`
`34`	`35`	`{`
	`36`	`+ context = newMigrationContext()`
`35`	`37`	`context.OriginalTableName = "a123456789012345678901234567890123456789012345678901234567890123"`
`36`	`38`	`oldTableName := context.GetOldTableName()`
`37`	`39`	`test.S(t).ExpectEquals(oldTableName, "_a1234567890123456789012345678901234567890123456789012345678_del")`
`38`	`40`	`}`
`39`	`41`	`{`
	`42`	`+ context = newMigrationContext()`
`40`	`43`	`context.OriginalTableName = "a123456789012345678901234567890123456789012345678901234567890123"`
`41`	`44`	`context.TimestampOldTable = true`
`42`	`45`	`longForm := "Jan 2, 2006 at 3:04pm (MST)"`
`@@ -45,9 +48,9 @@ func TestGetTableNames(t *testing.T) {`
`45`	`48`	`test.S(t).ExpectEquals(oldTableName, "_a1234567890123456789012345678901234567890123_20130203195400_del")`
`46`	`49`	`}`
`47`	`50`	`{`
	`51`	`+ context = newMigrationContext()`
`48`	`52`	`context.OriginalTableName = "foo_bar_baz"`
`49`	`53`	`context.ForceTmpTableName = "tmp"`
`50`		`- context.TimestampOldTable = false`
`51`	`54`	`test.S(t).ExpectEquals(context.GetOldTableName(), "_tmp_del")`
`52`	`55`	`test.S(t).ExpectEquals(context.GetGhostTableName(), "_tmp_gho")`
`53`	`56`	`test.S(t).ExpectEquals(context.GetChangelogTableName(), "_tmp_ghc")`