Include deprecation banner on all versions that share the oldest deprecation date (#59218)

Author: sarahs

src/app/lib/main-context-adapter.ts

@@ -40,6 +40,7 @@ export function adaptAppRouterContextToMainContext(
       oldestSupported: '',
       nextDeprecationDate: '',
       supported: [],
+      releasesWithOldestDeprecationDate: [],
     },
     enterpriseServerVersions: [],
     error: '',

src/frame/components/context/MainContext.tsx

@@ -86,6 +86,7 @@ type EnterpriseServerReleases = {
   oldestSupported: string
   nextDeprecationDate: string
   supported: Array<string>
+  releasesWithOldestDeprecationDate: Array<string>
 }
 
 export type MainContextT = {
@@ -193,7 +194,11 @@ export const getMainContext = async (req: any, res: any): Promise<MainContextT>
 
   // To know whether we need this key, we need to match this
   // with the business logic in `DeprecationBanner.tsx` which is as follows:
-  if (req.context.currentVersion.includes(req.context.enterpriseServerReleases.oldestSupported)) {
+  if (
+    req.context.enterpriseServerReleases.releasesWithOldestDeprecationDate.includes(
+      req.context.currentRelease,
+    )
+  ) {
     reusables.enterprise_deprecation = {
       version_was_deprecated: req.context.getDottedData(
         'reusables.enterprise_deprecation.version_was_deprecated',
@@ -264,6 +269,7 @@ export const getMainContext = async (req: any, res: any): Promise<MainContextT>
       'oldestSupported',
       'nextDeprecationDate',
       'supported',
+      'releasesWithOldestDeprecationDate',
     ]),
     enterpriseServerVersions: req.context.enterpriseServerVersions,
     error: req.context.error ? req.context.error.toString() : '',

src/versions/components/DeprecationBanner.tsx

@@ -9,8 +9,9 @@ import styles from './DeprecationBanner.module.scss'
 export const DeprecationBanner = () => {
   const { data, enterpriseServerReleases } = useMainContext()
   const { currentVersion } = useVersion()
+  const currentRelease = currentVersion.replace('enterprise-server@', '')
 
-  if (!currentVersion.includes(enterpriseServerReleases.oldestSupported)) {
+  if (!enterpriseServerReleases.releasesWithOldestDeprecationDate.includes(currentRelease)) {
     return null
   }
 

src/versions/lib/enterprise-server-releases.d.ts

@@ -42,6 +42,7 @@ export const oldestSupported: string
 export const dates: Dates
 export const nextDeprecationDate: string
 export const isOldestReleaseDeprecated: boolean
+export const releasesWithOldestDeprecationDate: string[]
 export const deprecatedOnNewSite: string[]
 export const deprecatedReleasesWithLegacyFormat: string[]
 export const deprecatedReleasesWithNewFormat: string[]

src/versions/lib/enterprise-server-releases.ts

@@ -127,6 +127,12 @@ export const isOldestReleaseDeprecated = nextDeprecationDate
   ? new Date() > new Date(nextDeprecationDate)
   : false
 
+// Find any other releases that may share the oldest deprecation date
+// We'll want to display the deprecation banner on all of these releases (not just oldest)
+export const releasesWithOldestDeprecationDate = Object.entries(dates)
+  .filter(([, versionData]) => versionData.deprecationDate === nextDeprecationDate)
+  .map(([version]) => version)
+
 // Filtered version arrays for different use cases
 export const deprecatedOnNewSite = deprecated.filter((version) =>
   versionSatisfiesRange(version, '>=2.13'),
@@ -210,6 +216,7 @@ export default {
   oldestSupported,
   nextDeprecationDate,
   isOldestReleaseDeprecated,
+  releasesWithOldestDeprecationDate,
   deprecatedOnNewSite,
   dates,
   firstVersionDeprecatedOnNewSite,

src/versions/tests/enterprise-versions.ts

@@ -2,8 +2,15 @@ import { describe, expect, test } from 'vitest'
 
 import patterns from '@/frame/lib/patterns'
 import EnterpriseServerReleases from '@/versions/lib/enterprise-server-releases'
-const { supported, deprecated, all, latest, oldestSupported, nextDeprecationDate } =
-  EnterpriseServerReleases
+const {
+  supported,
+  deprecated,
+  all,
+  latest,
+  oldestSupported,
+  nextDeprecationDate,
+  releasesWithOldestDeprecationDate,
+} = EnterpriseServerReleases
 
 describe('enterpriseServerReleases module', () => {
   test('includes an array of `supported` versions', async () => {
@@ -37,4 +44,10 @@ describe('enterpriseServerReleases module', () => {
   test('has a `nextDeprecationDate` property', async () => {
     expect(nextDeprecationDate).toMatch(patterns.ymd)
   })
+
+  test('has a `releasesWithOldestDeprecationDate` property', async () => {
+    expect(Array.isArray(releasesWithOldestDeprecationDate)).toBe(true)
+    expect(releasesWithOldestDeprecationDate.length).toBeGreaterThan(0)
+    expect(releasesWithOldestDeprecationDate).toContain(oldestSupported)
+  })
 })