Skip to content

Commit b46f447

Browse files
committed
Add banner role to logo container in sidebar header
All page content must be contained by landmarks: https://dequeuniversity.com/rules/axe/4.1/region
1 parent d4d7017 commit b46f447

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

includes/header.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
<header class="container-xl px-3 px-md-6 pt-3 pb-2 position-relative d-flex flex-justify-between width-full {% if error == '404' %} d-md-none {% endif %}">
77

8-
<div class="d-flex flex-items-center d-lg-none" style="z-index: 3;" id="github-logo-mobile">
8+
<div class="d-flex flex-items-center d-lg-none" style="z-index: 3;" id="github-logo-mobile" role="banner">
99
<a href="/{{ currentLanguage }}" aria-hidden="true" tabindex="-1">
1010
{% octicon "mark-github" height="32" class="text-black" %}
1111
</a>

includes/sidebar.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!-- product > category > maptopic > article -->
22
<div class="sidebar d-none d-lg-block">
33

4-
<div class="d-flex flex-items-center p-4 position-sticky top-0 sidebar-background-color" style="z-index: 3;" id="github-logo">
4+
<div class="d-flex flex-items-center p-4 position-sticky top-0 sidebar-background-color" style="z-index: 3;" id="github-logo" role="banner">
55
<a href="/{{ currentLanguage }}" class="text-white" aria-hidden="true" tabindex="-1">
66
{% octicon "mark-github" height="32" %}
77
</a>

0 commit comments

Comments
 (0)