Merge branch 'main' into main

jmarlena · web-flow · commit b3960f378478 · 2020-12-16T11:04:47.000-08:00
diff --git a/.github/workflows/repo-sync-stalls.yml b/.github/workflows/repo-sync-stalls.yml
@@ -40,7 +40,7 @@ jobs:
               const timeDelta = Date.now() - Date.parse(pr.created_at);
               const minutesOpen = timeDelta / 1000 / 60;
 
-              if (minutesOpen > 30) {
+              if (minutesOpen > 180) {
                 core.setFailed('Repo sync appears to be stalled') 
               }
             })
diff --git a/content/actions/guides/building-and-testing-nodejs.md b/content/actions/guides/building-and-testing-nodejs.md
@@ -195,7 +195,7 @@ steps:
 
 To authenticate to your private registry, you'll need to store your npm authentication token as a secret. For example, create a repository secret called `NPM_TOKEN`. For more information, see "[Creating and using encrypted secrets](/actions/automating-your-workflow-with-github-actions/creating-and-using-encrypted-secrets)."
 
-In the example below, the secret `NPM_TOKEN` stores the npm authentication token. The `setup-node` action configures the *.npmrc* file to read the npm authentication token from the `NODE_AUTH_TOKEN` environment variable. When using the `setup-node` action to create an *.npmrc* file, you must set the `NPM_AUTH_TOKEN` environment variable with the secret that contains your npm authentication token.
+In the example below, the secret `NPM_TOKEN` stores the npm authentication token. The `setup-node` action configures the *.npmrc* file to read the npm authentication token from the `NODE_AUTH_TOKEN` environment variable. When using the `setup-node` action to create an *.npmrc* file, you must set the `NODE_AUTH_TOKEN` environment variable with the secret that contains your npm authentication token.
 
 Before installing dependencies, use the `setup-node` action to create the *.npmrc* file. The action has two input parameters. The `node-version` parameter sets the Node.js version, and the `registry-url` parameter sets the default registry. If your package registry uses scopes, you must use the `scope` parameter. For more information, see [`npm-scope`](https://docs.npmjs.com/misc/scope).
 
diff --git a/content/actions/index.md b/content/actions/index.md
@@ -25,18 +25,15 @@ featuredLinks:
     - /actions/reference/workflow-commands-for-github-actions
     - /actions/reference/environment-variables
 changelog:
+  - title: Workflow visualization
+    date: '2020-12-08'
+    href: https://github.blog/changelog/2020-12-08-github-actions-workflow-visualization/
   - title: Removing set-env and add-path commands on November 16
     date: '2020-11-09'
     href: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
   - title: Ubuntu-latest workflows will use Ubuntu-20.04
     date: '2020-10-29'
     href: https://github.blog/changelog/2020-10-29-github-actions-ubuntu-latest-workflows-will-use-ubuntu-20-04
-  - title: MacOS Big Sur Preview
-    date: '2020-10-29'
-    href: https://github.blog/changelog/2020-10-29-github-actions-macos-big-sur-preview
-  - title: Self-Hosted Runner Group Access Changes
-    date: '2020-10-16'
-    href: https://github.blog/changelog/2020-10-16-github-actions-self-hosted-runner-group-access-changes/
 
 product_video: https://www.youtube-nocookie.com/embed/cP0I9w2coGU
   
diff --git a/content/actions/learn-github-actions/finding-and-customizing-actions.md b/content/actions/learn-github-actions/finding-and-customizing-actions.md
@@ -79,7 +79,7 @@ steps:
 
 #### Using branches
 
-Referring to a specific branch means that the action will always use include the latest updates on the target branch, but can create problems if those updates include breaking changes. This example targets a branch named `@main`:
+Referring to a specific branch means that the action will always use the latest updates on the target branch, but can create problems if those updates include breaking changes. This example targets a branch named `@main`:
 
 ```yaml
 steps:
diff --git a/content/admin/configuration/configuring-email-for-notifications.md b/content/admin/configuration/configuring-email-for-notifications.md
@@ -18,6 +18,7 @@ Notification emails are sent if there is activity on a repository a user is watc
 Your dedicated technical account manager in {% data variables.contact.github_support %} can configure email for notifications to be sent through your SMTP server. Make sure you include the following details in your support request.
 
 - Your SMTP server address
+- Login information to authenticate to the server: username and password
 - The port your SMTP server uses to send email
 - The domain name that your SMTP server will send with a HELO response, if any
 - The type of encryption used by your SMTP server
diff --git a/content/developers/webhooks-and-events/securing-your-webhooks.md b/content/developers/webhooks-and-events/securing-your-webhooks.md
@@ -72,7 +72,7 @@ end
 {% if currentVersion == "free-pro-team@latest" or currentVersion ver_gt "enterprise-server@2.22" or currentVersion == "github-ae@latest" %}
 def verify_signature(payload_body)
   signature = 'sha256=' + OpenSSL::HMAC.hexdigest(OpenSSL::Digest.new('sha256'), ENV['SECRET_TOKEN'], payload_body)
-  return halt 500, "Signatures didn't match!" unless Rack::Utils.secure_compare(signature, request.env['HTTP_X_HUB_SIGNATURE_2'])
+  return halt 500, "Signatures didn't match!" unless Rack::Utils.secure_compare(signature, request.env['HTTP_X_HUB_SIGNATURE_256'])
 end{% elsif currentVersion ver_lt "enterprise-server@2.23" %}
 def verify_signature(payload_body)
   signature = 'sha1=' + OpenSSL::HMAC.hexdigest(OpenSSL::Digest.new('sha1'), ENV['SECRET_TOKEN'], payload_body)
diff --git a/content/graphql/overview/resource-limitations.md b/content/graphql/overview/resource-limitations.md
@@ -125,7 +125,7 @@ These two examples show how to calculate the total nodes in a call.
 
                    = 22,060 total nodes</pre>
 
-### Rate limit
+## Rate limit
 
 The GraphQL API v4 limit is different from the REST API v3's [rate limits](/rest/overview/resources-in-the-rest-api#rate-limiting).
 
@@ -136,13 +136,7 @@ To accurately represent the server cost of a query, the GraphQL API v4 calculate
 * The formula uses the `first` and `last` arguments on a parent connection and its children to pre-calculate the potential load on GitHub's systems, such as MySQL, ElasticSearch, and Git.
 * Each new connection has its own point value. Points are combined with other points from the call into an overall rate limit score.
 
-The GraphQL API v4 rate limit is **5,000 points per hour**.
-
-{% if currentVersion == "free-pro-team@latest" %}
-
-For {% data variables.product.prodname_github_apps %} or {% data variables.product.prodname_oauth_app %}s that belong to a {% data variables.product.prodname_ghe_cloud %} account, requests to resources owned by the same {% data variables.product.prodname_ghe_cloud %} account have an increased limit of 15,000 points per hour.
-
-{% endif %}
+The GraphQL API v4 rate limit is **5,000 points per hour**. 
 
 Note that 5,000 points per hour is not the same as 5,000 calls per hour: the GraphQL API v4 and REST API v3 use different rate limits.
 
diff --git a/content/packages/index.md b/content/packages/index.md
@@ -19,15 +19,15 @@ featuredLinks:
     - /packages/guides/enabling-improved-container-support
     - /packages/guides/configuring-rubygems-for-use-with-github-packages
 changelog:
+  - title: ghcr.io container names redirect to the container page
+    date: '2020-12-14'
+    href: https://github.blog/changelog/2020-12-14-ghcr-io-container-names-redirect-to-the-container-page/
+  - title: Filter for tagged and untagged containers
+    date: '2020-12-14'
+    href: https://github.blog/changelog/2020-12-14-packages-can-filter-for-tagged-and-untagged-containers/
   - title: Packages container support is an opt-in beta
     date: '2020-11-17'
     href: https://docs.github.com/packages/getting-started-with-github-container-registry/enabling-improved-container-support
-  - title: Organization admins access to containers
-    date: '2020-11-16'
-    href: https://github.blog/changelog/2020-11-16-packages-organization-admins-access-to-containers/
-  - title: Packages now respects IP allow list settings
-    date: '2020-11-12'
-    href: https://github.blog/changelog/2020-11-12-packages-now-respects-ip-allow-list-settings/
 redirect_from:
   - /github/managing-packages-with-github-packages
   - /categories/managing-packages-with-github-package-registry
diff --git a/data/reusables/dependabot/supported-package-managers.md b/data/reusables/dependabot/supported-package-managers.md
@@ -25,6 +25,8 @@ Terraform: `terraform` | **✓** | |
 
 -`yarn` (v1 only) (specify `npm`)
 
+-`.gradle.tks` files, for Kotlin projects (specify `gradle`)
+
 -`pipenv`, `pip-compile`, and `poetry` (specify `pip`)
 
 For example, if you use `poetry` to manage your Python dependencies and want {% data variables.product.prodname_dependabot %} to monitor your dependency manifest file for new versions, use `package-ecosystem: "pip"` in your *dependabot.yml* file.
diff --git a/data/reusables/notifications/outbound_email_tip.md b/data/reusables/notifications/outbound_email_tip.md
@@ -1,9 +1,7 @@
-{% if enterpriseServerVersions contains currentVersion %}
-
+{% if enterpriseServerVersions contains currentVersion or currentVersion == "github-ae@latest" %}
 {% note %}
 
 **Note**: You'll only receive email notifications if outbound email support is enabled on {% data variables.product.product_location %}. For more information, contact your site administrator.
 
 {% endnote %}
-
 {% endif %}
diff --git a/lib/failbot.js b/lib/failbot.js
@@ -76,7 +76,7 @@ module.exports = class FailBot {
    * @param {Error} error
    * @param {any} metadata
    */
-  async sendException (error, metadata) {
+  async sendException (error, metadata = {}) {
     const data = Object.assign({ app: this.app }, this.getFailbotContext(), metadata)
     const body = this.formatJSON(error, Object.assign({ app: this.app }, data))
 
diff --git a/lib/handle-exceptions.js b/lib/handle-exceptions.js
@@ -1,8 +1,16 @@
-process.on('uncaughtException', err => {
+const FailBot = require('./failbot')
+
+process.on('uncaughtException', async err => {
   if (err.code === 'MODULE_NOT_FOUND') {
     console.error('\n\n🔥 Uh oh! It looks you are missing a required npm module.')
     console.error('Please run `npm install` to make sure you have all the required dependencies.\n\n')
   }
 
   console.error(err)
+  await FailBot.report(err)
+})
+
+process.on('unhandledRejection', async err => {
+  console.error(err)
+  await FailBot.report(err)
 })
diff --git a/middleware/breadcrumbs.js b/middleware/breadcrumbs.js
@@ -22,6 +22,10 @@ module.exports = async (req, res, next) => {
   const productPath = path.posix.join('/', req.context.currentProduct)
   const product = req.context.siteTree[req.language][req.context.currentVersion].products[req.context.currentProduct]
 
+  if (!product) {
+    return next()
+  }
+
   req.context.breadcrumbs.product = {
     href: path.posix.join('/', req.context.currentVersion, productPath),
     title: product.title
@@ -95,6 +99,5 @@ module.exports = async (req, res, next) => {
       title: articleTitle
     }
   }
-
   return next()
 }
diff --git a/stylesheets/nav.scss b/stylesheets/nav.scss
@@ -90,3 +90,9 @@ header summary,
     background: transparent;
   }
 }
+
+.nav-dropdown  {
+  @media (min-width: 1012px) and (max-width: 1279px) {
+    right: 0;
+  }
+}

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ jobs:`
`40`	`40`	`const timeDelta = Date.now() - Date.parse(pr.created_at);`
`41`	`41`	`const minutesOpen = timeDelta / 1000 / 60;`
`42`	`42`
`43`		`- if (minutesOpen > 30) {`
	`43`	`+ if (minutesOpen > 180) {`
`44`	`44`	`core.setFailed('Repo sync appears to be stalled')`
`45`	`45`	`}`
`46`	`46`	`})`