Skip to content

Commit a8bcc51

Browse files
heiskrCopilotCopilot
authored
Clarify backtick escaping instruction for gh cli (#59846)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: heiskr <1221423+heiskr@users.noreply.github.com>
1 parent 4c16416 commit a8bcc51

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/instructions/all.instructions.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,3 @@ When you create a pull request:
2929
3. Label with "llm-generated".
3030
4. If an issue exists, include "fixes owner/repo#issue" or "towards owner/repo#issue" as appropriate.
3131
5. Always create PRs in **draft mode** using `--draft` flag.
32-
6. When you are using gh cli, always _escape backticks_.

.github/instructions/code.instructions.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,16 @@ For code reviews, follow guidelines, tests, and validate instructions. For creat
99
## Guidelines
1010

1111
- If available, use ripgrep (`rg`) instead of `grep`.
12-
- When using gh cli, always _escape backticks_.
12+
- When using gh cli in double-quoted strings, escape backticks to prevent bash command substitution. In single-quoted strings, backticks do not need escaping.
1313
- All scripts should be listed in `package.json` and use `tsx`.
1414
- Whenever you create or comment on an issue or pull request, indicate you are GitHub Copilot.
1515
- Be careful fetching full HTML pages off the internet. Prefer to use MCP or gh cli whenever possible for github.com. Limit the number of tokens when grabbing HTML.
1616
- Avoid pull requests with over 300 lines of code changed. When significantly larger, offer to split up into smaller pull requests if possible.
1717
- All new code should be written in TypeScript and not JavaScript.
1818
- We use absolute imports, relative to the `src` directory, using the `@` symbol. For example, `getRedirect` which lives in `src/redirects/lib/get-redirect.ts` can be imported with `import getRedirect from '@/redirects/lib/get-redirect'`. The same rule applies for TypeScript (`.ts`) imports, e.g. `import type { GeneralSearchHit } from '@/search/types'`
1919
- For updates to the content linter, read important information in `src/content-linter/README.md`.
20+
- Do not commit to `main` branch.
21+
- Do not use git force push, and avoid git rebase.
2022

2123
## Tests
2224

0 commit comments

Comments
 (0)