Skip to content

Commit a017660

Browse files
heiskrheiskr
authored
Include header/footer components across layout types (#18377)
* Flesh out our layouts to include header/footer components across layout types * Update contribution.html * Remove extra line that we don't need when we have the gray section
1 parent ddad608 commit a017660

8 files changed

Lines changed: 31 additions & 14 deletions

‎includes/contribution.html‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,12 @@
22
<div class="f5 contribution">
33
<h2 class="f4">{% data ui.contribution_cta.title %}</h2>
44
<p class="text-gray f6">{% data ui.contribution_cta.body %}</p>
5-
<a class="btn btn-outline" href={{ "https://github.com/github/docs/edit/main/content/" | append: page.relativePath }}>
5+
{% if page.relativePath %}
6+
{% assign contribution_href = "https://github.com/github/docs/edit/main/content/" | append: page.relativePath %}
7+
{% else %}
8+
{% assign contribution_href = "https://github.com/github/docs" %}
9+
{% endif %}
10+
<a class="btn btn-outline" href="{{ contribution_href }}">
611
{% octicon "git-pull-request" height="16" %}
712
{% data ui.contribution_cta.button %}
813
</a>

‎layouts/enterprise-server-releases.html‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@
66
{% include sidebar %}
77

88
<main class="width-full">
9+
{% include header %}
10+
{% include deprecation-banner %}
11+
912
<main class="container-xl px-3 px-md-6 my-4 my-lg-4 d-xl-flex">
1013
<article class="markdown-body width-full">
1114
<div class="d-lg-flex flex-justify-between"></div>
@@ -52,8 +55,9 @@ <h2 id="deprecated-on-developer.github.com"><a href="#deprecated-on-developer.gi
5255
{% for version in enterpriseServerReleases.deprecatedReleasesOnDeveloperSite %}
5356
<li><a href="https://developer.github.com/enterprise/{{version}}">Enterprise Server {{version}}</a></li>
5457
{% endfor %}
55-
{% include support %}
58+
{% include support-section %}
5659
{% include small-footer %}
60+
{% include scroll-button %}
5761
</div>
5862
</div>
5963
</article>

‎layouts/error-404.html‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
<!doctype html>
12
{% assign error = '404' %}
23
<html lang="{{currentLanguage}}">
34
{% include head %}
@@ -31,8 +32,9 @@ <h3 class="mb-3">{% data ui.search.need_help %}</h3>
3132
</div>
3233

3334
<!-- {{ content }} -->
34-
{% include support %}
35+
{% include support-section %}
3536
{% include small-footer %}
37+
{% include scroll-button %}
3638
</main>
3739
</body>
3840
</html>

‎layouts/error-500.html‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
<!doctype html>
12
<html lang="{{currentLanguage}}">
23
{% include head %}
34
<body>
@@ -21,7 +22,8 @@ <h1>{% data ui.errors.oops %}</h1>
2122
</div>
2223

2324
<!-- {{ content }} -->
24-
{% include support %}
25+
{% include support-section %}
2526
{% include small-footer %}
27+
{% include scroll-button %}
2628
</body>
2729
</html>

‎layouts/graphql-explorer.html‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
<main class="width-full">
99
{% include header %}
10+
{% include deprecation-banner %}
1011

1112
<main class="container-xl px-3 px-md-6 my-4 my-lg-4 d-xl-flex">
1213
<article class="markdown-body width-full">
@@ -32,8 +33,9 @@ <h1 class="border-bottom-0">{{ page.title }}</h1>
3233
</article>
3334
</main>
3435

35-
{% include support %}
36+
{% include support-section %}
3637
{% include small-footer %}
38+
{% include scroll-button %}
3739
</main>
3840
</body>
3941
</html>

‎layouts/product-landing.html‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
<main class="width-full">
99
{% include header %}
10+
{% include deprecation-banner %}
1011

1112
<div class="container-xl px-3 px-md-6 pt-3 pb-2">
1213
<header class="d-lg-flex gutter-lg mb-6">
@@ -142,9 +143,9 @@ <h2 class="font-mktg h1 mb-2">Guides</h2>
142143
{% endif %}
143144
</div>
144145

145-
<div class="border-top">
146-
{% include small-footer %}
147-
</div>
146+
{% include support-section %}
147+
{% include small-footer %}
148+
{% include scroll-button %}
148149
</main>
149150
</body>
150151
</html>

‎layouts/product-sublanding.html‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99

1010
<main class="width-full overflow-auto">
1111
{% include header %}
12+
{% include deprecation-banner %}
1213

1314
<div class="bg-gray">
1415
<div class="container-xl px-3 px-md-6 pt-3 pb-2">
@@ -108,9 +109,9 @@ <h5 class="flex-auto pr-2">{{ guide.title }}</h5>
108109
</div>
109110
{% endif %}
110111

111-
<div class="border-top">
112-
{% include small-footer %}
113-
</div>
112+
{% include support-section %}
113+
{% include small-footer %}
114+
{% include scroll-button %}
114115
</main>
115116
</body>
116117
</html>

‎layouts/release-notes.html‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -162,9 +162,9 @@ <h4 id="{{ slug }}" class="release-notes-section-heading text-uppercase text-bol
162162
</aside>
163163
</div>
164164

165-
<div class="border-top">
166-
{% include small-footer %}
167-
</div>
165+
{% include support-section %}
166+
{% include small-footer %}
167+
{% include scroll-button %}
168168
</main>
169169
</body>
170170
</html>

0 commit comments

Comments
 (0)