Restore legal workflow (#54905)

Author: hectorsector

.github/actions/get-changed-files/action.yml

@@ -2,7 +2,7 @@ name: Get changed files
 description: Get a list of changed files
 
 inputs:
-  file_filter:
+  files:
     description: 'Files or directories to check for changes, supports names, directories, trailing slashes, and single trailing wildcard'
     required: false
     default: '.'

.github/actions/get-changed-files/get-changed-files.sh

@@ -58,23 +58,25 @@ if [ "$FILTER" != "." ]; then
   echo "$DIFF"
 fi
 
-# Format the output
 echo "__ formatting output __"
-FORMATTED_DIFF=$(echo $DIFF | tr '\n' ' ' | tr -s ' ')
-echo "$FORMATTED_DIFF"
+FORMATTED_DIFF=$(echo "$DIFF" | tr '\n' ' ' | tr -s ' ' | sed 's/^ *//' | sed 's/ *$//')
+echo "Formatted diff: '$FORMATTED_DIFF'"
 
 # Set the output for GitHub Actions
-if [[ -n "$GITHUB_OUTPUT" ]]; then
-  ALL_FORMATTED=$(echo "$DIFF" | tr '\n' ' ' | tr -s ' ')
-  echo "all_changed_files=$ALL_FORMATTED" >> "$GITHUB_OUTPUT"
-  echo "filtered_changed_files=$FORMATTED_DIFF" >> "$GITHUB_OUTPUT"
-else
-  echo "all_changed_files=$DIFF"
-  echo "filtered_changed_files=$FORMATTED_DIFF"
-fi
-
-# If output file is specified, write the filtered changes to it
 if [[ -n "$INPUT_OUTPUT_FILE" ]]; then
-  echo "$FORMATTED_DIFF" > "$INPUT_OUTPUT_FILE"
-  echo "__ wrote changes to $INPUT_OUTPUT_FILE __"
+  ALL_FORMATTED=$(echo "$DIFF" | tr '\n' ' ' | tr -s ' ' | sed 's/^ *//' | sed 's/ *$//')
+
+  # Only set outputs if there are actually changed files
+  if [[ -z "$ALL_FORMATTED" ]]; then
+    echo "No changed files detected, setting empty outputs"
+    echo "all_changed_files=" >> "$INPUT_OUTPUT_FILE"
+    echo "filtered_changed_files=" >> "$INPUT_OUTPUT_FILE"
+  else
+    echo "Setting non-empty outputs"
+    echo "all_changed_files=$ALL_FORMATTED" >> "$INPUT_OUTPUT_FILE"
+    echo "filtered_changed_files=$FORMATTED_DIFF" >> "$INPUT_OUTPUT_FILE"
+  fi
+else
+  echo "all_changed_files='$DIFF'"
+  echo "filtered_changed_files='$FORMATTED_DIFF'"
 fi

.github/workflows/content-lint-markdown.yml

@@ -24,8 +24,6 @@ jobs:
     steps:
       - name: Check out repo
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
-        with:
-          fetch-depth: 10
 
       - name: Set up Node and dependencies
         uses: ./.github/actions/node-npm-setup

.github/workflows/reviewers-legal.yml

@@ -33,31 +33,23 @@ jobs:
     steps:
       - name: Check out repo
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
-        with:
-          # Picking this number is a "best guess". If we make it too large,
-          # the checkout will take potentially unnecessarily long.
-          # This reduces the chance that tj-actions/changed-files has to
-          # fetch deeper history. But if it needs to, it will.
-          fetch-depth: 10
 
       - name: Get changed files
-        id: changed-files
-        uses: tj-actions/changed-files@40853de9f8ce2d6cfdc73c1b96f14e22ba44aec4 # v45.0.0
+        id: changed_files
+        uses: ./.github/actions/get-changed-files
         with:
           files: 'content/**'
-          output_renamed_files_as_deleted_and_added: true
 
       - name: Set up Node and dependencies
-        if: steps.changed-files.outputs.any_changed == 'true'
+        if: steps.changed_files.outputs.filtered_changed_files
         uses: ./.github/actions/node-npm-setup
 
       - name: Check content type
-        if: steps.changed-files.outputs.any_changed == 'true'
+        if: steps.changed_files.outputs.filtered_changed_files
         id: checkContentType
         run: npm run check-content-type
         env:
-          # all_changed_files does not include deleted files
-          CHANGED_FILE_PATHS: ${{ steps.changed-files.outputs.all_changed_files }}
+          CHANGED_FILE_PATHS: ${{ steps.changed_files.outputs.filtered_changed_files }}
           CONTENT_TYPE: 'rai'
 
       - name: Check for reviewers-legal label, add if missing and request review