[AI Search] debounce time 1ms -> 250ms + reduce frequency of search event instrumentation (#54755)

Author: ashishkeshan

src/search/components/helpers/execute-search-actions.ts

@@ -80,17 +80,7 @@ export async function executeCombinedSearch(
   query: string,
   debug = false,
   abortSignal?: AbortSignal,
-  eventGroupId?: string,
 ) {
-  sendEvent({
-    type: EventType.search,
-    // TODO: Remove PII so we can include the actual query
-    search_query: 'REDACTED',
-    search_context: COMBINED_SEARCH_CONTEXT,
-    eventGroupKey: SEARCH_OVERLAY_EVENT_GROUP,
-    eventGroupId: eventGroupId,
-  })
-
   let language = router.locale || 'en'
 
   const params = new URLSearchParams({ query: query, version, language })

src/search/components/hooks/useAISearchAutocomplete.ts

@@ -14,7 +14,6 @@ type UseCombinedSearchProps = {
   router: NextRouter
   currentVersion: string
   debug: boolean
-  eventGroupIdRef: React.MutableRefObject<string>
 }
 
 type UseCombinedSearchReturn = {
@@ -26,7 +25,7 @@ type UseCombinedSearchReturn = {
   clearAutocompleteResults: () => void
 }
 
-const DEBOUNCE_TIME = 1 // In milliseconds
+const DEBOUNCE_TIME = 250 // In milliseconds
 
 // Results are only cached for the current session
 // We cache results so if a user presses backspace, we can show the results immediately without burdening the API
@@ -46,7 +45,6 @@ export function useCombinedSearchResults({
   router,
   currentVersion,
   debug,
-  eventGroupIdRef,
 }: UseCombinedSearchProps): UseCombinedSearchReturn {
   const [searchOptions, setSearchOptions] = useState<SearchOptions>({
     aiAutocompleteOptions: [],
@@ -102,7 +100,6 @@ export function useCombinedSearchResults({
           queryValue,
           debug,
           controller.signal, // Pass in the signal to allow the request to be aborted
-          eventGroupIdRef.current,
         )
 
         const results = {

src/search/components/input/SearchOverlay.tsx

@@ -105,7 +105,6 @@ export function SearchOverlay({
     router,
     currentVersion,
     debug,
-    eventGroupIdRef: searchEventGroupId,
   })
 
   const { aiAutocompleteOptions, generalSearchResults, totalGeneralSearchResults } =
@@ -275,6 +274,14 @@ export function SearchOverlay({
 
   // When a general option is selected, open the article in the current window
   const generalSearchResultOnSelect = (selectedOption: GeneralSearchHit) => {
+    sendEvent({
+      type: EventType.search,
+      // TODO: Remove PII so we can include the actual query
+      search_query: 'REDACTED',
+      search_context: GENERAL_SEARCH_CONTEXT,
+      eventGroupKey: SEARCH_OVERLAY_EVENT_GROUP,
+      eventGroupId: searchEventGroupId.current,
+    })
     sendEvent({
       type: EventType.searchResult,
       search_result_query: urlSearchInputQuery,