Merge branch 'support-hardcoded-version-or-plan-in-link' of github.com:github/docs-internal into support-hardcoded-version-or-plan-in-link

sarahs · sarahs · commit 840d1825aebd · 2020-12-14T15:45:18.000-05:00
diff --git a/lib/rewrite-local-links.js b/lib/rewrite-local-links.js
@@ -35,7 +35,7 @@ function getNewHref (link, languageCode, version) {
   // /enterprise-server/rest/reference/oauth-authorizations (this redirects to the latest version)
   // /enterprise-server@latest/rest/reference/oauth-authorizations (this redirects to the latest version)
   const firstLinkSegment = href.split('/')[1]
-  if (supportedPlans.includes(firstLinkSegment) || supportedVersions.includes(firstLinkSegment) || firstLinkSegment === 'enterprise-server@latest') {
+  if ([...supportedPlans, ...supportedVersions,  'enterprise-server@latest'].includes(firstLinkSegment)) {
     newHref = pathUtils.getPathWithLanguage(href, languageCode)
   }
 

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ function getNewHref (link, languageCode, version) {`
`35`	`35`	`// /enterprise-server/rest/reference/oauth-authorizations (this redirects to the latest version)`
`36`	`36`	`// /enterprise-server@latest/rest/reference/oauth-authorizations (this redirects to the latest version)`
`37`	`37`	`const firstLinkSegment = href.split('/')[1]`
`38`		`- if (supportedPlans.includes(firstLinkSegment) \|\| supportedVersions.includes(firstLinkSegment) \|\| firstLinkSegment === 'enterprise-server@latest') {`
	`38`	`+ if ([...supportedPlans, ...supportedVersions, 'enterprise-server@latest'].includes(firstLinkSegment)) {`
`39`	`39`	`newHref = pathUtils.getPathWithLanguage(href, languageCode)`
`40`	`40`	`}`
`41`	`41`