Merge pull request #42812 from github/repo-sync

Repo sync

Author: docs-bot

.github/instructions/all.instructions.md

@@ -12,9 +12,9 @@ When you create a pull request:
 
 1. **Always** make the first line of the PR description the following (in italics):
 
-   `_Copilot Chat generated this pull request._`
+   `_GitHub Copilot generated this pull request._`
 
-2. Optionally, you may include a collapsed section summarizing the prompt or discussion with Copilot Chat:
+2. Optionally, you may include a collapsed section summarizing the prompt or discussion with Copilot:
 
    ```markdown
    <details><summary>Prompt summary - submitted by @GITHUB-USER-ID</summary>
@@ -29,4 +29,4 @@ When you create a pull request:
 3. Label with "llm-generated". 
 4. If an issue exists, include "fixes owner/repo#issue" or "towards owner/repo#issue" as appropriate. 
 5. Always create PRs in **draft mode** using `--draft` flag.
-6. Always _escape backticks_ when you use gh cli.
+6. When you are using gh cli, always _escape backticks_.

.github/instructions/code.instructions.md

@@ -9,10 +9,10 @@ For code reviews, follow guidelines, tests, and validate instructions. For creat
 ## Guidelines
 
 - If available, use ripgrep (`rg`) instead of `grep`.
-- Make sure to always _escape backticks_ when using gh cli.
+- When using gh cli, always _escape backticks_.
 - All scripts should be listed in `package.json` and use `tsx`.
-- Whenever you create or comment on an issue or pull request, indicate you are an LLM.
-- Be careful fetching full HTML pages off the internet. Prefer to use gh cli whenever possible for github.com. Limit the number of tokens when grabbing HTML.
+- Whenever you create or comment on an issue or pull request, indicate you are GitHub Copilot.
+- Be careful fetching full HTML pages off the internet. Prefer to use MCP or gh cli whenever possible for github.com. Limit the number of tokens when grabbing HTML.
 - Avoid pull requests with over 300 lines of code changed. When significantly larger, offer to split up into smaller pull requests if possible.
 - All new code should be written in TypeScript and not JavaScript.
 - We use absolute imports, relative to the `src` directory, using the `@` symbol. For example, `getRedirect` which lives in `src/redirects/lib/get-redirect.ts` can be imported with `import getRedirect from '@/redirects/lib/get-redirect'`. The same rule applies for TypeScript (`.ts`) imports, e.g. `import type { GeneralSearchHit } from '@/search/types'`
@@ -43,7 +43,7 @@ Run the following commands to validate your changes:
 
 0. Ask the human if they would like you to follow these steps.
 1. If this is new work, make sure you have the latest changes by running `git checkout main && git pull`. If this is existing work, update the branch you are working on with the head branch -- usually `main`.
-2. If the human provides a GitHub issue, use gh cli to read the issue and all comments.
+2. If the human provides a GitHub issue, use MCP or gh cli to read the issue and all comments.
 3. Begin by evaluating impact, effort, and estimate non-test lines of code that will change. Ask for more context and examples if needed.
 4. If you are running in agentic mode, _stop_ at this point and request approval from the human.
 5. If you need to add or change tests, work on tests before implementing.
@@ -52,7 +52,7 @@ Run the following commands to validate your changes:
 8. Validate that any new or changed tests pass. See "Tests".
 9. Validate that these changes meet our guidelines. See "Guidelines".
 10. If you are running in agentic mode, _stop_ at this point and request review before continuing. Suggest how the human should review the changes.
-11. If a branch and pull request already exist, commit and push, then _concisely_ comment on the pull request that you are an LLM and what changes you made and why. 
+11. If a branch and pull request already exist, commit and push, then _concisely_ comment on the pull request that you are GitHub Copilot and what changes you made and why. 
 12. If this is new work and no pull request exists yet, make a pull request:
     - label "llm-generated"
     - draft mode
@@ -61,4 +61,4 @@ Run the following commands to validate your changes:
 14. If you are in agentic mode, offer to do any or all of:
     - mark the pull request as ready,
     - assign the issue to the human if it is not already assigned, 
-    - _concisely_ comment on the issue explaining the change, indicating you are an LLM.
+    - _concisely_ comment on the issue explaining the change, indicating you are GitHub Copilot.

src/content-linter/lib/linting-rules/rai-reusable-usage.ts

@@ -10,7 +10,7 @@ import type { RuleParams, RuleErrorCallback, Rule } from '../../types'
 interface Frontmatter {
   type?: string
   // Allow any additional frontmatter properties since we only care about 'type'
-  [key: string]: any
+  [key: string]: unknown
 }
 
 interface LiquidToken {

src/content-render/scripts/cta-builder.ts

@@ -18,6 +18,19 @@ interface CTAParams {
   ref_style?: string
 }
 
+const CTA_PARAM_KEYS: (keyof CTAParams)[] = ['ref_product', 'ref_plan', 'ref_type', 'ref_style']
+
+interface CTASchemaProperty {
+  type: string
+  name: string
+  description: string
+  enum: string[]
+}
+
+type CTASchemaProperties = {
+  [K in keyof CTAParams]-?: CTASchemaProperty
+}
+
 // Conversion mappings from old CTA format to new schema
 const ctaToTypeMapping: Record<string, string> = {
   'GHEC trial': 'trial',
@@ -153,27 +166,40 @@ function extractCTAParams(url: string): CTAParams {
   const urlObj = new URL(url)
   const ctaParams: CTAParams = {}
   for (const [key, value] of urlObj.searchParams.entries()) {
-    if (key.startsWith('ref_')) {
-      ;(ctaParams as any)[key] = value
+    if (key.startsWith('ref_') && CTA_PARAM_KEYS.includes(key as keyof CTAParams)) {
+      ctaParams[key as keyof CTAParams] = value
     }
   }
   return ctaParams
 }
 
+interface AjvErrorParams {
+  missingProperty?: string
+  allowedValues?: string[]
+  additionalProperty?: string
+}
+
+interface AjvError {
+  keyword: string
+  instancePath: string
+  message?: string
+  params: AjvErrorParams
+}
+
 // Process AJV validation errors into readable messages
-function formatValidationErrors(ctaParams: CTAParams, errors: any[]): string[] {
+function formatValidationErrors(ctaParams: CTAParams, errors: AjvError[]): string[] {
   const errorMessages: string[] = []
   for (const error of errors) {
     let message = ''
     if (error.keyword === 'required') {
-      message = `Missing required parameter: ${(error.params as any)?.missingProperty}`
+      message = `Missing required parameter: ${error.params.missingProperty}`
     } else if (error.keyword === 'enum') {
       const paramName = error.instancePath.substring(1)
       const invalidValue = ctaParams[paramName as keyof CTAParams]
-      const allowedValues = (error.params as any)?.allowedValues || []
+      const allowedValues = error.params.allowedValues || []
       message = `Invalid value for ${paramName}: "${invalidValue}". Valid values are: ${allowedValues.join(', ')}`
     } else if (error.keyword === 'additionalProperties') {
-      message = `Unexpected parameter: ${(error.params as any)?.additionalProperty}`
+      message = `Unexpected parameter: ${error.params.additionalProperty}`
     } else {
       message = `Validation error: ${error.message}`
     }
@@ -191,7 +217,7 @@ function validateCTAParams(params: CTAParams): { isValid: boolean; errors: strin
     return { isValid: true, errors: [] }
   }
 
-  const errors = formatValidationErrors(params, ajvErrors)
+  const errors = formatValidationErrors(params, ajvErrors as unknown as AjvError[])
   return {
     isValid: false,
     errors,
@@ -382,12 +408,14 @@ async function interactiveBuilder(): Promise<void> {
 
     // Required parameters
     console.log(chalk.white(`\nRequired parameters:`))
+    const schemaProps = ctaSchema.properties as CTASchemaProperties
 
     for (const requiredParam of ctaSchema.required) {
-      ;(params as any)[requiredParam] = await selectFromOptions(
+      const paramKey = requiredParam as keyof CTAParams
+      params[paramKey] = await selectFromOptions(
         requiredParam,
-        (ctaSchema.properties as any)[requiredParam].description,
-        (ctaSchema.properties as any)[requiredParam].enum,
+        schemaProps[paramKey].description,
+        schemaProps[paramKey].enum,
         prompt,
       )
     }
@@ -399,15 +427,16 @@ async function interactiveBuilder(): Promise<void> {
     const optionalProperties = allProperties.filter((prop) => !ctaSchema.required.includes(prop))
 
     for (const optionalParam of optionalProperties) {
+      const paramKey = optionalParam as keyof CTAParams
       const includeParam = await confirmChoice(
-        `Include ${(ctaSchema.properties as any)[optionalParam].name.toLowerCase()}?`,
+        `Include ${schemaProps[paramKey].name.toLowerCase()}?`,
         prompt,
       )
       if (includeParam) {
-        ;(params as any)[optionalParam] = await selectFromOptions(
+        params[paramKey] = await selectFromOptions(
           optionalParam,
-          (ctaSchema.properties as any)[optionalParam].description,
-          (ctaSchema.properties as any)[optionalParam].enum,
+          schemaProps[paramKey].description,
+          schemaProps[paramKey].enum,
           prompt,
         )
       }

src/content-render/tests/liquid-helpers.ts

@@ -3,14 +3,13 @@ import { afterAll, beforeAll, describe, expect, test, vi } from 'vitest'
 import { liquid } from '@/content-render/index'
 import languages from '@/languages/lib/languages-server'
 import { DataDirectory } from '@/tests/helpers/data-directory'
+import type { Context } from '@/types'
 
 describe('liquid helper tags', () => {
   vi.setConfig({ testTimeout: 60 * 1000 })
 
-  // Using 'any' type as context is a test fixture with dynamic properties set in beforeAll
-  const context: any = {}
-  // Using 'any' type as DataDirectory is from data-directory.ts which lacks type definitions
-  let dd: any
+  const context: Partial<Context> = {}
+  let dd: DataDirectory
   const enDirBefore = languages.en.dir
 
   beforeAll(() => {

src/content-render/tests/liquid-tags.ts

@@ -31,9 +31,10 @@ describe('liquid-tags script integration tests', () => {
         stdio: 'pipe',
         timeout: 30000,
       })
-    } catch (error: any) {
-      output = error.stdout + error.stderr
-      exitCode = error.status || 1
+    } catch (error: unknown) {
+      const execError = error as { stdout?: string; stderr?: string; status?: number }
+      output = (execError.stdout || '') + (execError.stderr || '')
+      exitCode = execError.status || 1
     }
 
     return { output, exitCode }

src/events/components/is-headless.ts

@@ -2,7 +2,7 @@
 
 declare global {
   interface Window {
-    GHDOCSPLAYWRIGHT: any
+    GHDOCSPLAYWRIGHT: boolean | number
   }
 }
 

src/frame/middleware/context/product-examples.ts

@@ -16,7 +16,7 @@ function getProductExampleData(
   try {
     return getDataByLanguage(`product-examples.${product}.${key}`, language)
   } catch (error) {
-    if (error instanceof Error && (error as any).code === 'ENOENT') return
+    if (error instanceof Error && 'code' in error && error.code === 'ENOENT') return
     throw error
   }
 }

src/frame/tests/find-page.ts

@@ -5,6 +5,7 @@ import { describe, expect, test, vi } from 'vitest'
 
 import Page from '@/frame/lib/page'
 import findPage from '@/frame/lib/find-page'
+import type { Page as PageType } from '@/types'
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url))
 
@@ -31,7 +32,7 @@ describe('find page', () => {
 
     const redirectedPage = findPage(
       redirectToFind,
-      pageMap as any, // Using any due to type conflicts between different Page type definitions
+      pageMap as unknown as Record<string, PageType>,
       page.buildRedirects(),
     )
     expect(redirectedPage).toBeDefined()

src/observability/logger/middleware/get-automatic-request-logger.ts

@@ -33,7 +33,7 @@ export function getAutomaticRequestLogger() {
     const originalEnd = res.end
 
     // Override res.end to log when response completes
-    res.end = function (chunk?: any, encoding?: any) {
+    res.end = function (...args: unknown[]) {
       const responseTime = Date.now() - startTime
       const status = res.statusCode || 200
       const contentLength = res.getHeader('content-length') || '-'
@@ -59,7 +59,7 @@ export function getAutomaticRequestLogger() {
 
         // Don't log `/_next/` requests unless LOG_LEVEL is `debug` or higher
         if (url?.startsWith('/_next/') && logLevelNum < 3) {
-          return originalEnd.call(this, chunk, encoding)
+          return originalEnd.apply(this, args as Parameters<typeof originalEnd>)
         }
 
         // Choose color based on status code
@@ -80,7 +80,7 @@ export function getAutomaticRequestLogger() {
       }
 
       // Call the original end method to complete the response
-      return originalEnd.call(this, chunk, encoding)
+      return originalEnd.apply(this, args as Parameters<typeof originalEnd>)
     }
 
     next()