repo sync

Author: Octomerger

middleware/archived-enterprise-versions-assets.js

@@ -30,8 +30,8 @@ module.exports = async (req, res, next) => {
     res.set('x-robots-tag', 'noindex')
     // Allow the browser and Fastly to cache these
     res.set('cache-control', `public, max-age=${ONE_DAY}`)
-    res.send(r.body)
+    return res.send(r.body)
   } catch (err) {
-    next()
+    return next()
   }
 }

middleware/archived-enterprise-versions.js

@@ -46,15 +46,15 @@ module.exports = async (req, res, next) => {
       res.set('location', staticRedirect[1])
     }
 
-    res.send(r.body)
+    return res.send(r.body)
   } catch (err) {
     for (const fallbackRedirect of getFallbackRedirects(req, requestedVersion) || []) {
       try {
         await got(getProxyPath(fallbackRedirect, requestedVersion))
         return res.redirect(301, fallbackRedirect)
       } catch (err) { } // noop
     }
-    next()
+    return next()
   }
 }
 

middleware/disable-caching-on-safari.js

@@ -3,5 +3,5 @@ module.exports = (req, res, next) => {
   if (isSafari) {
     res.header('Last-Modified', (new Date()).toUTCString())
   }
-  next()
+  return next()
 }

middleware/render-page.js

@@ -115,6 +115,7 @@ module.exports = async function renderPage (req, res, next) {
   const output = await liquid.parseAndRender(layout, context)
 
   // First, send the response so the user isn't waiting
+  // NOTE: Do NOT `return` here as we still need to cache the response afterward!
   res.send(output)
 
   // Finally, save output to cache for the next time around

middleware/set-fastly-surrogate-key.js

@@ -8,5 +8,5 @@ module.exports = (req, res, next) => {
   // https://docs.fastly.com/en/guides/getting-started-with-surrogate-keys
   res.set('surrogate-key', 'all-the-things')
 
-  next()
+  return next()
 }