Remove any types from 16 files (#59772)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: heiskr

eslint.config.ts

@@ -193,7 +193,6 @@ export default [
       'src/article-api/scripts/generate-api-docs.ts',
       'src/article-api/transformers/audit-logs-transformer.ts',
       'src/article-api/transformers/rest-transformer.ts',
-      'src/assets/scripts/validate-asset-images.ts',
       'src/automated-pipelines/tests/rendering.ts',
       'src/codeql-cli/scripts/convert-markdown-for-docs.ts',
       'src/content-linter/lib/helpers/get-lintable-yml.ts',
@@ -226,27 +225,18 @@ export default [
       'src/content-render/scripts/move-content.ts',
       'src/content-render/tests/data.ts',
       'src/content-render/tests/link-error-line-numbers.ts',
-      'src/content-render/unified/alerts.ts',
       'src/content-render/unified/annotate.ts',
-      'src/content-render/unified/code-header.ts',
-      'src/content-render/unified/copilot-prompt.ts',
       'src/content-render/unified/index.ts',
       'src/content-render/unified/module-types.d.ts',
-      'src/content-render/unified/rewrite-empty-table-rows.ts',
-      'src/content-render/unified/rewrite-for-rowheaders.ts',
       'src/content-render/unified/rewrite-local-links.ts',
       'src/data-directory/lib/data-directory.ts',
-      'src/data-directory/lib/data-schemas/features.ts',
       'src/data-directory/lib/data-schemas/learning-tracks.ts',
       'src/data-directory/lib/get-data.ts',
       'src/data-directory/scripts/find-orphaned-features/find.ts',
-      'src/dev-toc/generate.ts',
       'src/early-access/scripts/migrate-early-access-product.ts',
       'src/early-access/scripts/what-docs-early-access-branch.ts',
       'src/fixtures/tests/categories-and-subcategory.ts',
-      'src/fixtures/tests/glossary.ts',
       'src/fixtures/tests/guides.ts',
-      'src/fixtures/tests/homepage.ts',
       'src/fixtures/tests/liquid.ts',
       'src/fixtures/tests/markdown.ts',
       'src/fixtures/tests/translations.ts',
@@ -267,10 +257,7 @@ export default [
       'src/ghes-releases/scripts/deprecate/update-content.ts',
       'src/github-apps/lib/index.ts',
       'src/graphql/lib/index.ts',
-      'src/graphql/pages/breaking-changes.tsx',
-      'src/graphql/pages/changelog.tsx',
       'src/graphql/pages/reference.tsx',
-      'src/graphql/pages/schema-previews.tsx',
       'src/graphql/scripts/build-changelog.ts',
       'src/graphql/scripts/utils/process-previews.ts',
       'src/graphql/scripts/utils/process-schemas.ts',
@@ -285,7 +272,6 @@ export default [
       'src/landings/pages/home.tsx',
       'src/landings/pages/product.tsx',
       'src/languages/lib/correct-translation-content.ts',
-      'src/languages/lib/get-alert-titles.ts',
       'src/languages/lib/render-with-fallback.ts',
       'src/languages/lib/translation-utils.ts',
       'src/learning-track/lib/process-learning-tracks.ts',
@@ -324,12 +310,10 @@ export default [
       'src/search/scripts/index/index-cli.ts',
       'src/search/scripts/index/utils/indexing-elasticsearch-utils.ts',
       'src/search/scripts/scrape/lib/parse-page-sections-into-records.ts',
-      'src/search/tests/topics.ts',
       'src/tests/helpers/check-url.ts',
       'src/tests/helpers/e2etest.ts',
       'src/tests/scripts/copy-fixture-data.ts',
       'src/tests/vitest.setup.ts',
-      'src/tools/components/Picker.tsx',
       'src/types/github__markdownlint-github.d.ts',
       'src/types/markdownlint-lib-rules.d.ts',
       'src/types/markdownlint-rule-helpers.d.ts',

src/assets/scripts/validate-asset-images.ts

@@ -115,8 +115,8 @@ async function checkFile(filePath: string) {
     }
     try {
       checkSVGContent(content)
-    } catch (error: any) {
-      return [CRITICAL, filePath, error.message]
+    } catch (error: unknown) {
+      return [CRITICAL, filePath, error instanceof Error ? error.message : String(error)]
     }
   } else if (EXPECT[ext]) {
     const fileType = await fileTypeFromFile(filePath)

src/content-render/unified/alerts.ts

@@ -5,7 +5,7 @@ Custom "Alerts", based on similar filter/styling in the monolith code.
 import { visit } from 'unist-util-visit'
 import { h } from 'hastscript'
 import octicons from '@primer/octicons'
-import type { Element } from 'hast'
+import type { Element, Root, ElementContent } from 'hast'
 
 interface AlertType {
   icon: string
@@ -22,56 +22,56 @@ const alertTypes: Record<string, AlertType> = {
 
 // Must contain one of [!NOTE], [!IMPORTANT], ...
 const ALERT_REGEXP = new RegExp(`\\[!(${Object.keys(alertTypes).join('|')})\\]`, 'gi')
-
-// Using any due to conflicting unist/hast type definitions between dependencies
-const matcher = (node: any): boolean =>
-  node.type === 'element' &&
-  node.tagName === 'blockquote' &&
-  ALERT_REGEXP.test(JSON.stringify(node.children))
+// Non-global version for .test() and .match() to avoid stateful lastIndex issues
+const ALERT_REGEXP_DETECT = new RegExp(`\\[!(${Object.keys(alertTypes).join('|')})\\]`, 'i')
 
 export default function alerts({ alertTitles = {} }: { alertTitles?: Record<string, string> }) {
-  // Using any due to conflicting unist/hast type definitions between dependencies
-  return (tree: any) => {
-    // Using any due to conflicting unist/hast type definitions between dependencies
-    visit(tree, matcher, (node: any) => {
-      const key = getAlertKey(node)
+  return (tree: Root) => {
+    visit(tree, 'element', (node) => {
+      const el = node as Element
+      if (el.tagName !== 'blockquote' || !ALERT_REGEXP_DETECT.test(JSON.stringify(el.children)))
+        return
+      const key = getAlertKey(el)
       if (!(key in alertTypes)) {
         console.warn(
           `Alert key '${key}' should be all uppercase (change it to '${key.toUpperCase()}')`,
         )
       }
-      const alertType = alertTypes[getAlertKey(node).toUpperCase()]
-      node.tagName = 'div'
-      node.properties.className = `ghd-alert ghd-alert-${alertType.color}`
-      node.properties.dataContainer = 'alert'
-      node.children = [
+      const alertType = alertTypes[getAlertKey(el).toUpperCase()]
+      el.tagName = 'div'
+      el.properties.className = `ghd-alert ghd-alert-${alertType.color}`
+      el.properties.dataContainer = 'alert'
+      el.children = [
         h(
           'p',
           { className: 'ghd-alert-title' },
           getOcticonSVG(alertType.icon),
           alertTitles[key] || '',
         ),
-        ...removeAlertSyntax(node.children),
+        ...removeAlertSyntax(el.children),
       ]
     })
   }
 }
 
 function getAlertKey(node: Element): string {
   const body = JSON.stringify(node.children)
-  const matches = body.match(ALERT_REGEXP)
+  const matches = body.match(ALERT_REGEXP_DETECT)
   return matches![0].slice(2, -1)
 }
 
-// Using any to handle both array and object node types recursively
-function removeAlertSyntax(node: any): any {
+function removeAlertSyntax(node: ElementContent[]): ElementContent[]
+function removeAlertSyntax(node: ElementContent): ElementContent
+function removeAlertSyntax(
+  node: ElementContent | ElementContent[],
+): ElementContent | ElementContent[] {
   if (Array.isArray(node)) {
-    return node.map(removeAlertSyntax)
+    return node.map((n) => removeAlertSyntax(n))
   }
-  if (node.children) {
-    node.children = node.children.map(removeAlertSyntax)
+  if ('children' in node) {
+    node.children = node.children.map((n) => removeAlertSyntax(n)) as typeof node.children
   }
-  if (node.value) {
+  if ('value' in node) {
     node.value = node.value.replace(ALERT_REGEXP, '')
   }
   return node

src/content-render/unified/code-header.ts

@@ -13,44 +13,40 @@ import { fromParse5 } from 'hast-util-from-parse5'
 import murmur from 'imurmurhash'
 import { getPrompt } from './copilot-prompt'
 import { generatePromptId } from '../lib/prompt-id'
-import type { Element } from 'hast'
+import type { Element, Root } from 'hast'
 
 interface LanguageConfig {
   name: string
-  // Using any for language properties that can vary (aliases, extensions, etc.)
-  [key: string]: any
+  [key: string]: string | string[] | boolean | undefined
 }
 
 type Languages = Record<string, LanguageConfig>
 
 const languages = yaml.load(fs.readFileSync('./data/code-languages.yml', 'utf8')) as Languages
 
-// Using any due to conflicting unist/hast type definitions between dependencies
-const matcher = (node: any): boolean =>
-  node.type === 'element' &&
-  node.tagName === 'pre' &&
-  // For now, limit to ones with the copy or prompt meta,
-  // but we may enable for all examples later.
-  (getPreMeta(node).copy || getPreMeta(node).prompt) &&
-  // Don't add this header for annotated examples.
-  !getPreMeta(node).annotate
-
 export default function codeHeader() {
-  // Using any due to conflicting unist/hast type definitions between dependencies
-  return (tree: any) => {
-    // Using any due to conflicting unist/hast type definitions between dependencies
-    visit(tree, matcher, (node: any, index: number | undefined, parent: any) => {
-      if (index !== undefined && parent) {
-        parent.children[index] = wrapCodeExample(node, tree)
+  return (tree: Root) => {
+    visit(tree, 'element', (node, index, parent) => {
+      const el = node as Element
+      if (
+        el.tagName !== 'pre' ||
+        !(getPreMeta(el).copy || getPreMeta(el).prompt) ||
+        getPreMeta(el).annotate
+      )
+        return
+      if (index !== undefined && parent && 'children' in parent) {
+        ;(parent as Element).children[index] = wrapCodeExample(el, tree)
       }
     })
   }
 }
 
-// Using any due to conflicting unist/hast type definitions between dependencies
-function wrapCodeExample(node: any, tree: any): Element {
-  const lang: string = node.children[0].properties.className?.[0].replace('language-', '')
-  const code: string = node.children[0].children[0].value
+function wrapCodeExample(node: Element, tree: Root): Element {
+  const codeChild = node.children[0] as Element
+  const classNames = codeChild.properties.className as string[] | undefined
+  const lang: string = classNames?.[0]?.replace('language-', '') ?? ''
+  const textNode = codeChild.children[0] as { value: string }
+  const code: string = textNode.value
 
   const subnav = null // getSubnav() lives in annotate.ts, not needed for normal code blocks
   const hasPrompt: boolean = Boolean(getPreMeta(node).prompt)
@@ -120,16 +116,14 @@ export function header(
 function btnIcon(): Element {
   const btnIconHtml: string = octicons.copy.toSVG()
   const btnIconAst = parse(String(btnIconHtml), { sourceCodeLocationInfo: true })
-  // Using any because fromParse5 expects VFile but we only have a string
-  // This is safe because parse5 only needs the string content
-  const btnIconElement = fromParse5(btnIconAst, { file: btnIconHtml as any })
+  const btnIconElement = fromParse5(btnIconAst)
   return btnIconElement as Element
 }
 
-// Using any due to conflicting unist/hast type definitions between dependencies
-// node can be various mdast/hast node types, return value contains meta properties from code blocks
-export function getPreMeta(node: any): Record<string, any> {
+// node can be various hast element types, return value contains meta properties from code blocks
+export function getPreMeta(node: Element): Record<string, unknown> {
   // Here's why this monstrosity works:
   // https://github.com/syntax-tree/mdast-util-to-hast/blob/c87cd606731c88a27dbce4bfeaab913a9589bf83/lib/handlers/code.js#L40-L42
-  return node.children[0]?.data?.meta || {}
+  const firstChild = node.children[0] as Element | undefined
+  return (firstChild?.data as Record<string, Record<string, unknown>> | undefined)?.meta || {}
 }

src/content-render/unified/copilot-prompt.ts

@@ -9,14 +9,13 @@ import { parse } from 'parse5'
 import { fromParse5 } from 'hast-util-from-parse5'
 import { getPreMeta } from './code-header'
 import { generatePromptId } from '../lib/prompt-id'
+import type { Element, Root } from 'hast'
 
-// node and tree are hast/unist AST nodes without proper TypeScript definitions
-// Returns an object with the prompt button element and the full prompt content
 export function getPrompt(
-  node: any,
-  tree: any,
+  node: Element,
+  tree: Root,
   code: string,
-): { element: any; promptContent: string } | null {
+): { element: Element; promptContent: string } | null {
   const hasPrompt = Boolean(getPreMeta(node).prompt)
   if (!hasPrompt) return null
 
@@ -40,11 +39,9 @@ export function getPrompt(
   return { element, promptContent }
 }
 
-// Using any because node and tree are hast/unist AST nodes without proper TypeScript definitions
-// node is the current code block element, tree is used to find referenced code blocks
 function buildPromptData(
-  node: any,
-  tree: any,
+  node: Element,
+  tree: Root,
   code: string,
 ): { promptContent: string; ariaLabel: string } {
   // Find a ref meta in the format 'ref=<id>'
@@ -56,14 +53,18 @@ function buildPromptData(
   }
 
   // If the 'ref=<id>' meta is found, find a matching code block to include as context in the prompt link.
-  const matchingCodeEl = findMatchingCode(ref, tree)
+  const matchingCodeEl = findMatchingCode(ref as string, tree)
   if (!matchingCodeEl) {
     console.warn(`Can't find referenced code block with id=${ref}`)
     return promptOnly(code)
   }
-  // Using any to access children property on untyped hast element node
   // AST structure: element -> code -> text node with value property
-  const matchingCode = (matchingCodeEl as any)?.children[0].children[0].value || null
+  const codeChild = matchingCodeEl.children[0] as Element | undefined
+  const textNode = codeChild?.children[0] as { value?: string } | undefined
+  const matchingCode = textNode?.value || null
+  if (!matchingCode) {
+    return promptOnly(code)
+  }
   return promptAndContext(code, matchingCode)
 }
 
@@ -84,21 +85,17 @@ function promptAndContext(
   }
 }
 
-// Using any because tree and node are hast/unist AST nodes without proper TypeScript definitions
-// Searches the AST tree for a code block with matching id in meta
-function findMatchingCode(ref: string, tree: any): any {
-  return find(tree, (node: any) => {
-    // Using any to access tagName property on untyped hast element node
-    return node.type === 'element' && (node as any).tagName === 'pre' && getPreMeta(node).id === ref
-  })
+function findMatchingCode(ref: string, tree: Root): Element | undefined {
+  return find<Element>(tree, ((node: { type: string; tagName?: string }) => {
+    return (
+      node.type === 'element' && node.tagName === 'pre' && getPreMeta(node as Element).id === ref
+    )
+  }) as Parameters<typeof find>[1])
 }
 
-// Returns a hast element node for the Copilot icon
-// Using any return type because fromParse5 returns untyped hast nodes
-function copilotIcon(): any {
+function copilotIcon(): Element {
   const copilotIconHtml = octicons.copilot.toSVG()
   const copilotIconAst = parse(String(copilotIconHtml), { sourceCodeLocationInfo: true })
-  // Using any because fromParse5 expects VFile but we only have a string
-  const copilotIconElement = fromParse5(copilotIconAst, { file: copilotIconHtml as any })
-  return copilotIconElement
+  const copilotIconElement = fromParse5(copilotIconAst)
+  return copilotIconElement as Element
 }

src/content-render/unified/rewrite-empty-table-rows.ts

@@ -1,4 +1,5 @@
 import { visit, SKIP } from 'unist-util-visit'
+import type { Element, Root } from 'hast'
 
 /**
  * Where it can mutate the AST to swap from:
@@ -49,31 +50,23 @@ import { visit, SKIP } from 'unist-util-visit'
  * isn't the same all the way down. But Unified will still parse it.
  * */
 
-// node is a hast element node without proper TypeScript definitions
-function matcher(node: any): boolean {
-  return node.type === 'element' && node.tagName === 'tr'
-}
-
-// node, parent, and grandChild are hast element nodes without proper TypeScript definitions
-function visitor(
-  node: any,
-  index: number | undefined,
-  parent: any,
-): [typeof SKIP, number] | undefined {
-  if (
-    node.children.every(
-      (grandChild: any) =>
-        grandChild.type === 'element' && grandChild.tagName === 'td' && !grandChild.children.length,
-    )
-  ) {
-    if (index !== undefined) {
-      parent.children.splice(index, 1)
-      return [SKIP, index]
-    }
-  }
-}
-
-// tree is a hast root node without proper TypeScript definitions
 export default function rewriteEmptyTableRows() {
-  return (tree: any) => visit(tree, matcher, visitor)
+  return (tree: Root) =>
+    visit(tree, 'element', (node, index, parent) => {
+      const el = node as Element
+      if (el.tagName !== 'tr') return
+      if (
+        el.children.every(
+          (grandChild) =>
+            grandChild.type === 'element' &&
+            grandChild.tagName === 'td' &&
+            !grandChild.children.length,
+        )
+      ) {
+        if (index !== undefined && parent) {
+          parent.children.splice(index, 1)
+          return [SKIP, index] as const
+        }
+      }
+    })
 }