Skip to content

Commit 6e0c231

Browse files
authored
Set engines.node to 14+ (#17777)
* Set engines.node * Add setup-node to browser-test workflow * Updoot ianwalter/puppeteer-container
1 parent d33a7a0 commit 6e0c231

3 files changed

Lines changed: 10 additions & 4 deletions

File tree

.github/allowed-actions.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ module.exports = [
1919
'fkirc/skip-duplicate-actions@36feb0d8d062137530c2e00bd278d138fe191289',
2020
'github/codeql-action/analyze@v1',
2121
'github/codeql-action/init@v1',
22-
'ianwalter/puppeteer@12728ddef82390d1ecd4732fb543f62177392fbb',
22+
'ianwalter/puppeteer-container@2466ba8ecf689ccf4e5dfadeff3ac2db227b2e17',
2323
'juliangruber/approve-pull-request-action@c530832d4d346c597332e20e03605aa94fa150a8',
2424
'juliangruber/find-pull-request-action@2fc55e82a6d5d36fe1e7f1848f7e64fd02d99de9',
2525
'juliangruber/read-file-action@e0a316da496006ffd19142f0fd594a1783f3b512',

.github/workflows/browser-test.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,20 @@ jobs:
3131
name: Checkout
3232
uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f
3333

34+
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
35+
name: Setup Node
36+
uses: actions/setup-node@c46424eee26de4078d34105d3de3cc4992202b1e
37+
with:
38+
node-version: 14.x
39+
3440
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
3541
name: Install
36-
uses: ianwalter/puppeteer@12728ddef82390d1ecd4732fb543f62177392fbb
42+
uses: ianwalter/puppeteer-container@2466ba8ecf689ccf4e5dfadeff3ac2db227b2e17
3743
with:
3844
args: npm ci
3945

4046
- if: ${{ needs.see_if_should_skip.outputs.should_skip != 'true' }}
4147
name: Test
42-
uses: ianwalter/puppeteer@12728ddef82390d1ecd4732fb543f62177392fbb
48+
uses: ianwalter/puppeteer-container@2466ba8ecf689ccf4e5dfadeff3ac2db227b2e17
4349
with:
4450
args: npm run browser-test

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@
190190
"heroku-postbuild": "node script/early-access/clone-for-build.js && npm run build"
191191
},
192192
"engines": {
193-
"node": "12 - 14"
193+
"node": ">= 14.0.0"
194194
},
195195
"repository": "https://github.com/github/docs",
196196
"husky": {

0 commit comments

Comments
 (0)