Move 404 and 500 images to local (#17432)

Author: heiskr

assets/images/site/labtocat.png

@@ -19,7 +19,7 @@ <h1>{% data ui.errors.oops %}</h1>
           </div>
 
           <div class="col-md-8 col-lg-6 mx-auto">
-            <img src="https://octodex.github.com/images/waldocat.png" alt="waldocat">
+            <img src="/assets/images/site/waldocat.png" alt="waldocat">
           </div>
 
           <div class="col-lg-12 mt-6">

assets/images/site/waldocat.png

@@ -16,7 +16,7 @@ <h1>{% data ui.errors.oops %}</h1>
           <pre><code>{{ error.stack }}</code></pre>
         {% endif %}
 
-        <img src="https://octodex.github.com/images/labtocat.png" alt="labtocat">
+        <img src="/assets/images/site/labtocat.png" alt="labtocat">
       </article>
     </div>
 

layouts/error-404.html

@@ -25,7 +25,6 @@ module.exports = async (req, res, next) => {
         'data:',
         'github.githubassets.com',
         'github-images.s3.amazonaws.com',
-        'octodex.github.com',
         'placehold.it',
         '*.githubusercontent.com',
         'github.com'

layouts/error-500.html

@@ -52,7 +52,6 @@ describe('server', () => {
 
     expect(csp.get('img-src').includes("'self'")).toBe(true)
     expect(csp.get('img-src').includes('github-images.s3.amazonaws.com')).toBe(true)
-    expect(csp.get('img-src').includes('octodex.github.com')).toBe(true)
 
     expect(csp.get('script-src').includes("'self'")).toBe(true)