Change app-level rate limiting code to 418 (#54772)

Author: heiskr

src/search/tests/api-ai-search.ts

@@ -188,7 +188,7 @@ describe('AI Search Routes', () => {
     })
 
     expect(response3.ok).toBe(false)
-    expect(response3.status).toBe(429)
+    // temporary, its 418 now ... expect(response3.status).toBe(429)
     newLimit = parseInt(response3.headers.get('ratelimit-limit') || '0')
     newRemaining = parseInt(response3.headers.get('ratelimit-remaining') || '0')
     expect(newLimit).toBe(limit)

src/shielding/middleware/rate-limit.ts

@@ -73,6 +73,9 @@ export function createRateLimiter(max = MAX, isAPILimiter = false) {
       noCacheControl(res)
       res.status(options.statusCode).send(options.message)
     },
+
+    // Temporary so that we can see what is coming from Fastly v app level
+    statusCode: 418, // "i'm a teapot"
   })
 }
 

src/shielding/tests/shielding.ts

@@ -155,7 +155,7 @@ describe('rate limiting', () => {
         'fastly-client-ip': 'abc123',
       },
     })
-    expect(res2.statusCode).toBe(429)
+    // temporary, its 418 now ... expect(res2.statusCode).toBe(429)
     expect(res2.headers['ratelimit-limit']).toBe('1')
     expect(res2.headers['ratelimit-remaining']).toBe('0')
   })