always warm the sever before listening (#23750)

Author: mikesurowiec

server.mjs

@@ -52,23 +52,15 @@ async function checkPortAvailability() {
 async function startServer() {
   const app = createApp()
 
-  // If in a deployed environment...
-  if (NODE_ENV === 'production') {
-    // If in a true production environment, wait for the cache to be fully warmed.
-    if (process.env.HEROKU_PRODUCTION_APP || process.env.GITHUB_ACTIONS) {
-      await warmServer()
-    }
-  } else {
-    // Warm up as soon as possible when in development.
-    // The `warmServer()` function is idempotent and it will soon be used
-    // by some middleware, but there's no point in having a started server
-    // without this warmed up. Besides, by starting this slow thing now,
-    // it can start immediately instead of waiting for the first request
-    // to trigger it to warm up. That way, when in development and triggering
-    // a `nodemon` restart, there's a good chance the warm up has come some
-    // way before you manage to reach for your browser to do a page refresh.
-    await warmServer()
-  }
+  // Warm up as soon as possible.
+  // The `warmServer()` function is idempotent and it will soon be used
+  // by some middleware, but there's no point in having a started server
+  // without this warmed up. Besides, by starting this slow thing now,
+  // it can start immediately instead of waiting for the first request
+  // to trigger it to warm up. That way, when in development and triggering
+  // a `nodemon` restart, there's a good chance the warm up has come some
+  // way before you manage to reach for your browser to do a page refresh.
+  await warmServer()
 
   // Workaround for https://github.com/expressjs/express/issues/1101
   const server = http.createServer(app)