Skip to content

Commit 5e1f14a

Browse files
sarahssarahs
committed
remove no longer needed tests
1 parent b47aaec commit 5e1f14a

3 files changed

Lines changed: 14 additions & 93 deletions

File tree

‎tests/fixtures/graphql-redirects.json‎

Lines changed: 0 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -75,18 +75,6 @@
7575
"/en/enterprise/2.19/v4/union": "/en/enterprise-server@2.19/graphql/reference/unions",
7676
"/en/enterprise/2.19/v4/union/assignee": "/en/enterprise-server@2.19/graphql/reference/unions#assignee",
7777
"/en/enterprise/2.19/v4/union/auditentryactor": "/en/enterprise-server@2.19/graphql/reference/unions#auditentryactor",
78-
"/en/enterprise/2.20/user/v4/enum": "/en/enterprise-server@2.20/graphql/reference/enums",
79-
"/en/enterprise/2.20/user/v4/guides": "/en/enterprise-server@2.20/graphql/guides",
80-
"/en/enterprise/2.20/user/v4/input_object": "/en/enterprise-server@2.20/graphql/reference/input-objects",
81-
"/en/enterprise/2.20/user/v4/interface": "/en/enterprise-server@2.20/graphql/reference/interfaces",
82-
"/en/enterprise/2.20/user/v4/mutation": "/en/enterprise-server@2.20/graphql/reference/mutations",
83-
"/en/enterprise/2.20/user/v4/object": "/en/enterprise-server@2.20/graphql/reference/objects",
84-
"/en/enterprise/2.20/user/v4/previews": "/en/enterprise-server@2.20/graphql/overview/schema-previews",
85-
"/en/enterprise/2.20/user/v4/public_schema": "/en/enterprise-server@2.20/graphql/overview/public-schema",
86-
"/en/enterprise/2.20/user/v4/query": "/en/enterprise-server@2.20/graphql/reference/queries",
87-
"/en/enterprise/2.20/user/v4/reference": "/en/enterprise-server@2.20/graphql/reference",
88-
"/en/enterprise/2.20/user/v4/scalar": "/en/enterprise-server@2.20/graphql/reference/scalars",
89-
"/en/enterprise/2.20/user/v4/union": "/en/enterprise-server@2.20/graphql/reference/unions",
9078
"/en/enterprise/2.20/v4/enum": "/en/enterprise-server@2.20/graphql/reference/enums",
9179
"/en/enterprise/2.20/v4/enum/auditlogorderfield": "/en/enterprise-server@2.20/graphql/reference/enums#auditlogorderfield",
9280
"/en/enterprise/2.20/v4/enum/checkannotationlevel": "/en/enterprise-server@2.20/graphql/reference/enums#checkannotationlevel",
@@ -109,18 +97,6 @@
10997
"/en/enterprise/2.20/v4/union": "/en/enterprise-server@2.20/graphql/reference/unions",
11098
"/en/enterprise/2.20/v4/union/assignee": "/en/enterprise-server@2.20/graphql/reference/unions#assignee",
11199
"/en/enterprise/2.20/v4/union/auditentryactor": "/en/enterprise-server@2.20/graphql/reference/unions#auditentryactor",
112-
"/en/enterprise/2.21/user/v4/enum": "/en/enterprise-server@2.21/graphql/reference/enums",
113-
"/en/enterprise/2.21/user/v4/guides": "/en/enterprise-server@2.21/graphql/guides",
114-
"/en/enterprise/2.21/user/v4/input_object": "/en/enterprise-server@2.21/graphql/reference/input-objects",
115-
"/en/enterprise/2.21/user/v4/interface": "/en/enterprise-server@2.21/graphql/reference/interfaces",
116-
"/en/enterprise/2.21/user/v4/mutation": "/en/enterprise-server@2.21/graphql/reference/mutations",
117-
"/en/enterprise/2.21/user/v4/object": "/en/enterprise-server@2.21/graphql/reference/objects",
118-
"/en/enterprise/2.21/user/v4/previews": "/en/enterprise-server@2.21/graphql/overview/schema-previews",
119-
"/en/enterprise/2.21/user/v4/public_schema": "/en/enterprise-server@2.21/graphql/overview/public-schema",
120-
"/en/enterprise/2.21/user/v4/query": "/en/enterprise-server@2.21/graphql/reference/queries",
121-
"/en/enterprise/2.21/user/v4/reference": "/en/enterprise-server@2.21/graphql/reference",
122-
"/en/enterprise/2.21/user/v4/scalar": "/en/enterprise-server@2.21/graphql/reference/scalars",
123-
"/en/enterprise/2.21/user/v4/union": "/en/enterprise-server@2.21/graphql/reference/unions",
124100
"/en/enterprise/2.21/v4/enum": "/en/enterprise-server@2.21/graphql/reference/enums",
125101
"/en/enterprise/2.21/v4/enum/auditlogorderfield": "/en/enterprise-server@2.21/graphql/reference/enums#auditlogorderfield",
126102
"/en/enterprise/2.21/v4/enum/checkannotationlevel": "/en/enterprise-server@2.21/graphql/reference/enums#checkannotationlevel",
@@ -277,18 +253,6 @@
277253
"/enterprise/2.19/v4/union": "/en/enterprise-server@2.19/graphql/reference/unions",
278254
"/enterprise/2.19/v4/union/assignee": "/en/enterprise-server@2.19/graphql/reference/unions#assignee",
279255
"/enterprise/2.19/v4/union/auditentryactor": "/en/enterprise-server@2.19/graphql/reference/unions#auditentryactor",
280-
"/enterprise/2.20/user/v4/enum": "/en/enterprise-server@2.20/graphql/reference/enums",
281-
"/enterprise/2.20/user/v4/guides": "/en/enterprise-server@2.20/graphql/guides",
282-
"/enterprise/2.20/user/v4/input_object": "/en/enterprise-server@2.20/graphql/reference/input-objects",
283-
"/enterprise/2.20/user/v4/interface": "/en/enterprise-server@2.20/graphql/reference/interfaces",
284-
"/enterprise/2.20/user/v4/mutation": "/en/enterprise-server@2.20/graphql/reference/mutations",
285-
"/enterprise/2.20/user/v4/object": "/en/enterprise-server@2.20/graphql/reference/objects",
286-
"/enterprise/2.20/user/v4/previews": "/en/enterprise-server@2.20/graphql/overview/schema-previews",
287-
"/enterprise/2.20/user/v4/public_schema": "/en/enterprise-server@2.20/graphql/overview/public-schema",
288-
"/enterprise/2.20/user/v4/query": "/en/enterprise-server@2.20/graphql/reference/queries",
289-
"/enterprise/2.20/user/v4/reference": "/en/enterprise-server@2.20/graphql/reference",
290-
"/enterprise/2.20/user/v4/scalar": "/en/enterprise-server@2.20/graphql/reference/scalars",
291-
"/enterprise/2.20/user/v4/union": "/en/enterprise-server@2.20/graphql/reference/unions",
292256
"/enterprise/2.20/v4/enum": "/en/enterprise-server@2.20/graphql/reference/enums",
293257
"/enterprise/2.20/v4/enum/auditlogorderfield": "/en/enterprise-server@2.20/graphql/reference/enums#auditlogorderfield",
294258
"/enterprise/2.20/v4/enum/checkannotationlevel": "/en/enterprise-server@2.20/graphql/reference/enums#checkannotationlevel",
@@ -311,18 +275,6 @@
311275
"/enterprise/2.20/v4/union": "/en/enterprise-server@2.20/graphql/reference/unions",
312276
"/enterprise/2.20/v4/union/assignee": "/en/enterprise-server@2.20/graphql/reference/unions#assignee",
313277
"/enterprise/2.20/v4/union/auditentryactor": "/en/enterprise-server@2.20/graphql/reference/unions#auditentryactor",
314-
"/enterprise/2.21/user/v4/enum": "/en/enterprise-server@2.21/graphql/reference/enums",
315-
"/enterprise/2.21/user/v4/guides": "/en/enterprise-server@2.21/graphql/guides",
316-
"/enterprise/2.21/user/v4/input_object": "/en/enterprise-server@2.21/graphql/reference/input-objects",
317-
"/enterprise/2.21/user/v4/interface": "/en/enterprise-server@2.21/graphql/reference/interfaces",
318-
"/enterprise/2.21/user/v4/mutation": "/en/enterprise-server@2.21/graphql/reference/mutations",
319-
"/enterprise/2.21/user/v4/object": "/en/enterprise-server@2.21/graphql/reference/objects",
320-
"/enterprise/2.21/user/v4/previews": "/en/enterprise-server@2.21/graphql/overview/schema-previews",
321-
"/enterprise/2.21/user/v4/public_schema": "/en/enterprise-server@2.21/graphql/overview/public-schema",
322-
"/enterprise/2.21/user/v4/query": "/en/enterprise-server@2.21/graphql/reference/queries",
323-
"/enterprise/2.21/user/v4/reference": "/en/enterprise-server@2.21/graphql/reference",
324-
"/enterprise/2.21/user/v4/scalar": "/en/enterprise-server@2.21/graphql/reference/scalars",
325-
"/enterprise/2.21/user/v4/union": "/en/enterprise-server@2.21/graphql/reference/unions",
326278
"/enterprise/2.21/v4/enum": "/en/enterprise-server@2.21/graphql/reference/enums",
327279
"/enterprise/2.21/v4/enum/auditlogorderfield": "/en/enterprise-server@2.21/graphql/reference/enums#auditlogorderfield",
328280
"/enterprise/2.21/v4/enum/checkannotationlevel": "/en/enterprise-server@2.21/graphql/reference/enums#checkannotationlevel",

‎tests/routing/deprecated-enterprise-versions.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ describe('enterprise deprecation', () => {
2424
expect(res.headers.location).toBe('/en/enterprise/2.13')
2525
})
2626

27-
test('workaround for lost frontmatter redirects works in deprecated enterprise content >=2.13', async () => {
27+
test.only('workaround for lost frontmatter redirects works in deprecated enterprise content >=2.13', async () => {
2828
const res = await get('/en/enterprise/2.15/user/articles/viewing-contributions-on-your-profile-page')
2929
expect(res.statusCode).toBe(301)
3030
expect(res.headers.location).toBe('/en/enterprise/2.15/user/articles/viewing-contributions-on-your-profile')

‎tests/routing/redirects.js‎

Lines changed: 13 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ describe('redirects', () => {
4040
expect(page.redirects[`/en/${nonEnterpriseDefaultVersion}/articles`]).toBe('/en/github')
4141
expect(page.redirects['/common-issues-and-questions']).toBe('/en/github')
4242
expect(page.redirects['/en/common-issues-and-questions']).toBe('/en/github')
43-
expect(page.redirects[`/en/enterprise/${enterpriseServerReleases.latest}/user/articles`]).toBe(`/en/enterprise-server@${enterpriseServerReleases.latest}/github`)
44-
expect(page.redirects[`/en/enterprise/${enterpriseServerReleases.latest}/user/common-issues-and-questions`]).toBe(`/en/enterprise-server@${enterpriseServerReleases.latest}/github`)
43+
expect(page.redirects[`/en/enterprise/${enterpriseServerReleases.latest}/articles`]).toBe(`/en/enterprise-server@${enterpriseServerReleases.latest}/github`)
44+
expect(page.redirects[`/en/enterprise/${enterpriseServerReleases.latest}/common-issues-and-questions`]).toBe(`/en/enterprise-server@${enterpriseServerReleases.latest}/github`)
4545
})
4646

4747
test('converts single `redirect_from` strings values into arrays', async () => {
@@ -205,18 +205,6 @@ describe('redirects', () => {
205205
expect(res.headers.location).toBe(enterpriseAdmin)
206206
})
207207

208-
test('admin/guides redirects to admin', async () => {
209-
const res = await get(`/en/enterprise/${enterpriseServerReleases.latest}/admin/guides`)
210-
expect(res.statusCode).toBe(301)
211-
expect(res.headers.location).toBe(enterpriseAdmin)
212-
})
213-
214-
test('no version plus admin/guides redirects to admin on latest version', async () => {
215-
const res = await get('/en/enterprise/admin/guides')
216-
expect(res.statusCode).toBe(301)
217-
expect(res.headers.location).toBe(enterpriseAdmin)
218-
})
219-
220208
test('admin/guides redirects to admin in redirects', async () => {
221209
const res = await get(`/en/enterprise/${enterpriseServerReleases.latest}/admin/guides/installation/upgrading-github-enterprise`)
222210
expect(res.statusCode).toBe(301)
@@ -231,12 +219,6 @@ describe('redirects', () => {
231219
expect(res.statusCode).toBe(301)
232220
expect(res.headers.location).toBe(japaneseEnterpriseAdmin)
233221
})
234-
235-
test('admin/guides redirects to admin (japanese)', async () => {
236-
const res = await get(`/ja/enterprise/${enterpriseServerReleases.latest}/admin/guides`)
237-
expect(res.statusCode).toBe(301)
238-
expect(res.headers.location).toBe(japaneseEnterpriseAdmin)
239-
})
240222
})
241223

242224
describe('enterprise user homepage', () => {
@@ -250,19 +232,19 @@ describe('redirects', () => {
250232
})
251233

252234
test('no language code redirects to english', async () => {
253-
const res = await get(`/enterprise/${enterpriseServerReleases.latest}/user/github`)
235+
const res = await get(`/enterprise/${enterpriseServerReleases.latest}/github`)
254236
expect(res.statusCode).toBe(301)
255237
expect(res.headers.location).toBe(enterpriseUser)
256238
})
257239

258240
test('no version redirects to latest version', async () => {
259-
const res = await get('/en/enterprise/user/github')
241+
const res = await get('/en/enterprise/github')
260242
expect(res.statusCode).toBe(301)
261243
expect(res.headers.location).toBe(enterpriseUser)
262244
})
263245

264246
test('no version redirects to latest version (japanese)', async () => {
265-
const res = await get('/ja/enterprise/user/github')
247+
const res = await get('/ja/enterprise/github')
266248
expect(res.statusCode).toBe(301)
267249
expect(res.headers.location).toBe(japaneseEnterpriseUser)
268250
})
@@ -273,7 +255,7 @@ describe('redirects', () => {
273255
const japaneseUserArticle = userArticle.replace('/en/', '/ja/')
274256

275257
test('no product redirects to GitHub.com product on the latest version', async () => {
276-
const res = await get(`/en/enterprise/${enterpriseServerReleases.latest}/user/articles/set-up-git`)
258+
const res = await get(`/en/enterprise/${enterpriseServerReleases.latest}/articles/set-up-git`)
277259
expect(res.statusCode).toBe(301)
278260
expect(res.headers.location).toBe(userArticle)
279261
})
@@ -285,19 +267,19 @@ describe('redirects', () => {
285267
})
286268

287269
test('no language code redirects to english', async () => {
288-
const res = await get(`/enterprise/${enterpriseServerReleases.latest}/user/github/getting-started-with-github/set-up-git`)
270+
const res = await get(`/enterprise/${enterpriseServerReleases.latest}/github/getting-started-with-github/set-up-git`)
289271
expect(res.statusCode).toBe(301)
290272
expect(res.headers.location).toBe(userArticle)
291273
})
292274

293275
test('no version redirects to latest version', async () => {
294-
const res = await get('/en/enterprise/user/github/getting-started-with-github/set-up-git')
276+
const res = await get('/en/enterprise/github/getting-started-with-github/set-up-git')
295277
expect(res.statusCode).toBe(301)
296278
expect(res.headers.location).toBe(userArticle)
297279
})
298280

299281
test('no version redirects to latest version (japanese)', async () => {
300-
const res = await get('/ja/enterprise/user/github/getting-started-with-github/set-up-git')
282+
const res = await get('/ja/enterprise/github/getting-started-with-github/set-up-git')
301283
expect(res.statusCode).toBe(301)
302284
expect(res.headers.location).toBe(japaneseUserArticle)
303285
})
@@ -309,50 +291,37 @@ describe('redirects', () => {
309291
const japaneseUserArticle = userArticle.replace('/en/', '/ja/')
310292

311293
test('redirects to expected article', async () => {
312-
const res = await get(`/en/enterprise/${enterpriseServerReleases.latest}/user${redirectFromPath}`)
294+
const res = await get(`/en/enterprise/${enterpriseServerReleases.latest}${redirectFromPath}`)
313295
expect(res.statusCode).toBe(301)
314296
expect(res.headers.location).toBe(userArticle)
315297
})
316298

317299
test('no language code redirects to english', async () => {
318-
const res = await get(`/enterprise/${enterpriseServerReleases.latest}/user${redirectFromPath}`)
300+
const res = await get(`/enterprise/${enterpriseServerReleases.latest}${redirectFromPath}`)
319301
expect(res.statusCode).toBe(301)
320302
expect(res.headers.location).toBe(userArticle)
321303
})
322304

323305
test('no version redirects to latest version', async () => {
324-
const res = await get(`/en/enterprise/user${redirectFromPath}`)
306+
const res = await get(`/en/enterprise${redirectFromPath}`)
325307
expect(res.statusCode).toBe(301)
326308
expect(res.headers.location).toBe(userArticle)
327309
})
328310

329311
test('no version redirects to latest version (japanese)', async () => {
330-
const res = await get(`/ja/enterprise/user${redirectFromPath}`)
312+
const res = await get(`/ja/enterprise${redirectFromPath}`)
331313
expect(res.statusCode).toBe(301)
332314
expect(res.headers.location).toBe(japaneseUserArticle)
333315
})
334316
})
335317

336318
describe('desktop guide', () => {
337319
const desktopGuide = '/en/desktop/contributing-and-collaborating-using-github-desktop/creating-an-issue-or-pull-request'
338-
const japaneseDesktopGuides = desktopGuide.replace('/en/', '/ja/')
339320

340321
test('no language code redirects to english', async () => {
341322
const res = await get('/desktop/contributing-and-collaborating-using-github-desktop/creating-an-issue-or-pull-request')
342323
expect(res.statusCode).toBe(301)
343324
expect(res.headers.location).toBe(desktopGuide)
344325
})
345-
346-
test('desktop/guides redirects to desktop', async () => {
347-
const res = await get('/en/desktop/guides/contributing-and-collaborating-using-github-desktop/creating-an-issue-or-pull-request')
348-
expect(res.statusCode).toBe(301)
349-
expect(res.headers.location).toBe(desktopGuide)
350-
})
351-
352-
test('desktop/guides redirects to desktop (japanese)', async () => {
353-
const res = await get('/ja/desktop/guides/contributing-and-collaborating-using-github-desktop/creating-an-issue-or-pull-request')
354-
expect(res.statusCode).toBe(301)
355-
expect(res.headers.location).toBe(japaneseDesktopGuides)
356-
})
357326
})
358327
})

0 commit comments

Comments
 (0)