Add a test for non-English rendering (#17593)

* Throw in some code that should fail a test

* Remove read-frontmatter behavior

* Unskip the test that would catch this

* Remove the throw to pass the test

Author: JasonEtco

…ise-accounts/payment-information-tab.md …rise-accounts/payment-information-tab.mddata/reusables/enterprise-accounts/payment-information-tab.md renamed to data/reusables/enterprise-accounts/payment-information-tab.md data/reusables/enterprise-accounts/payment-information-tab.md renamed to data/reusables/enterprise-accounts/payment-information-tab.md

@@ -1,11 +1,9 @@
 const assert = require('assert')
-const fs = require('fs')
 const path = require('path')
 const cheerio = require('cheerio')
 const patterns = require('./patterns')
 const getMapTopicContent = require('./get-map-topic-content')
 const getApplicableVersions = require('./get-applicable-versions')
-const encodeBracketedParentheses = require('./encode-bracketed-parentheses')
 const generateRedirectsForPermalinks = require('./redirects/permalinks')
 const getEnglishHeadings = require('./get-english-headings')
 const getTocItems = require('./get-toc-items')
@@ -14,11 +12,10 @@ const Permalink = require('./permalink')
 const languages = require('./languages')
 const renderContent = require('./render-content')
 const { renderReact } = require('./react/engine')
-const frontmatter = require('./frontmatter')
 const products = require('./all-products')
 const slash = require('slash')
 const statsd = require('./statsd')
-const fmfromf = require('./read-frontmatter')
+const readFileContents = require('./read-file-contents')
 const getLinkData = require('./get-link-data')
 const union = require('lodash/union')
 
@@ -40,7 +37,7 @@ class Page {
     // Per https://nodejs.org/api/fs.html#fs_fs_exists_path_callback
     // its better to read and handle errors than to check access/stats first
     try {
-      const { data, content, errors: frontmatterErrors } = await fmfromf(fullPath, opts.languageCode)
+      const { data, content, errors: frontmatterErrors } = await readFileContents(fullPath, opts.languageCode)
 
       return {
         ...opts,
@@ -138,20 +135,7 @@ class Page {
       : this.renderProp('title', context, opts)
   }
 
-  async getMarkdown () {
-    const raw = fs.readFileSync(this.fullPath, 'utf8')
-    const { content } = frontmatter(raw, { filepath: this.fullPath })
-    // prevent `[foo] (bar)` strings with a space between from being interpreted as markdown links
-    const encodedMarkdown = encodeBracketedParentheses(content)
-    return encodedMarkdown
-  }
-
   async _render (context) {
-    // Get the raw markdown if we need to
-    if (!this.markdown) {
-      this.markdown = await this.getMarkdown()
-    }
-
     // use English IDs/anchors for translated headings, so links don't break (see #8572)
     if (this.languageCode !== 'en') {
       const englishHeadings = getEnglishHeadings(this, context.pages)

lib/page.js

@@ -0,0 +1,19 @@
+const fs = require('fs')
+const encodeBracketedParentheses = require('./encode-bracketed-parentheses')
+const fm = require('./frontmatter')
+
+/**
+ * Read only the frontmatter from  file
+ */
+module.exports = async function fmfromf (filepath, languageCode) {
+  let fileContent = await fs.promises.readFile(filepath, 'utf8')
+
+  fileContent = encodeBracketedParentheses(fileContent)
+
+  // TODO remove this when crowdin-support issue 66 has been resolved
+  if (languageCode !== 'en' && fileContent.includes(': verdadero')) {
+    fileContent = fileContent.replace(': verdadero', ': true')
+  }
+
+  return fm(fileContent, { filepath })
+}

lib/read-file-contents.js

@@ -483,8 +483,9 @@ describe('server', () => {
 
 describe('URLs by language', () => {
   // TODO re-enable this test once TOCs are auto-generated (after PR 11731 has landed)
-  test.skip('heading IDs and links on translated pages are in English', async () => {
+  test('heading IDs and links on translated pages are in English', async () => {
     const $ = await getDOM('/ja/github/getting-started-with-github/verifying-your-email-address')
+    expect($.res.statusCode).toBe(200)
     expect($('h3[id="further-reading"]').length).toBe(1)
     expect($('h3[id="参考リンク"]').length).toBe(0)
     expect($('h3 a[href="#further-reading"]').length).toBe(1)